Repository navigation
Remove the ReScript-specific code - #228
Merged
Merged
Conversation
reanalyze analyzes OCaml only; the ReScript version is developed in the rescript monorepo. The code that only served ReScript goes: - @Gentype, @genType.import and @genType.opaque annotations kept the annotated value live (in implementations without an interface). They are now ordinary attributes: ProcessDeadAnnotations has only Dead and Live, and the doGenType flag through processAttributes, collectExportLocations and structure is gone with the cmti check that set it. - The workaround for ReScript's lowercase JSX, whose generated emptyArray referenced itself. - The BuckleScript unsafe_expr exclusion for primitives. The comment on doExternals no longer cites a BuckleScript issue; the behaviour is unchanged. A sweep of the 69 review repros is identical; the deadcode example gains an unused [@Gentype] value, now reported (the previous binary hid it). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT
Member
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
cknitt
marked this pull request as ready for review
November 5, 2026 09:14
cristianoc
approved these changes
Nov 5, 2026
This was referenced Nov 5, 2026
Merged
cknitt
added a commit
that referenced
this pull request
Nov 5, 2026
Releases the dead-code fixes of #224 (several build trees analyzed together, type re-exports, optional-argument aliases, functions passed as arguments, abbreviated function types), the move to an OCaml-only repository (#226-#228, #231, including the removal of @Gentype support) and the new minimum of OCaml 4.14 (#230). Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the npm/JS removal PR. Last step towards an OCaml-only repository: the code in
src/that only served ReScript goes.@genTypesupport:@genType,@genType.importand@genType.opaquekept the annotated value live (in implementations without an interface). They are now ordinary attributes.ProcessDeadAnnotationshas onlyDeadandLive.doGenTypeflag throughprocessAttributes,collectExportLocationsandstructureis gone, along with the.cmticheck that set it.emptyArrayreferencing itself.unsafe_exprexclusion for primitives.The comment on
doExternalsno longer cites a BuckleScript issue; the behaviour is unchanged.User-facing change, in
Changes.md: an unused[@genType]value is now reported. The deadcode example gains such a value (gentype_annotated) and its snapshot reports it. The previous binary didn't.Testing
dune test: passes.🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT