Repository navigation
Drop the ReScript namespace handling of module names - #231
Merged
Merged
Conversation
Paths.getModuleName derived a unit's module name from its source file and cut it at the first "-", for ReScript's namespaced files (Module-Project). OCaml module names cannot contain "-", and dune namespaces with "__", so for OCaml the name is the source file's base name without extension. Paths.ml goes. A sweep of the 69 review repros is identical, dune test passes, and the ReScript compiler's OCaml sources still analyze to 0 issues. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT
The previous commit removed Paths.ml but missed its only caller: the module name is now the source file's base name without extension. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT
cristianoc
approved these changes
Nov 5, 2026
Merged
cknitt
added a commit
that referenced
this pull request
Nov 5, 2026
Releases the dead-code fixes of #224 (several build trees analyzed together, type re-exports, optional-argument aliases, functions passed as arguments, abbreviated function types), the move to an OCaml-only repository (#226-#228, #231, including the removal of @Gentype support) and the new minimum of OCaml 4.14 (#230). Claude-Session: https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more ReScript leftover, missed by #228.
Paths.getModuleNamederived a unit's module name from its source file and cut it at the first-, for ReScript's namespaced files (Module-Project). OCaml module names can't contain-, and dune namespaces with__, so for OCaml the name is simply the source file's base name without extension.Paths.mlgoes.Testing:
dune test: passes.(Two commits because the first missed the caller; squash on merge.)
🤖 Generated with Claude Code
https://claude.ai/code/session_01Kbf3gLDo8mBJKpNE25WAwT