Remove pyrefly 1897 workarounds and use the strict preset - #3567
Merged
adamtheturtle merged 3 commits intoSep 7, 2026
Conversation
pyrefly 1.2.0 supports copy.replace, so the explicit annotations and ignore comments are no longer needed. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
September 7, 2026 21:23 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
adamtheturtle
temporarily deployed
to
vuforia
September 7, 2026 21:23 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
This was referenced Sep 7, 2026
The strict preset enables unused-ignore along with implicit-any, missing-override-decorator and other checks. Fix the new errors: add @OverRide decorators, replace an untyped lambda sort key with a typed function, and type two empty containers. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
facebook/pyrefly#1897 (support for
copy.replace) was closed on 2026-07-08 and the fix is in the pinned pyrefly 1.2.0. This removes theSee ...comments, the# pyrefly: ignore[bad-argument-type]comments, and the explicitImageTargetannotations that only existed to work around it.It also switches the pyrefly config to
preset = "strict"(see https://pyrefly.org/en/docs/configuration/), which enablesunused-ignoreso stale ignore comments like these fail the check in future, along withimplicit-any,missing-override-decoratorand others. The handful of new errors are fixed:@overridedecorators, a typed sort-key function instead of a lambda, and two typed empty containers.pyrefly, mypy and all prek hooks pass.
🤖 Generated with Claude Code