Skip to content

Use the pyrefly strict preset - #1578

Merged
adamtheturtle merged 4 commits into
mainfrom
unused-ignore-error
Sep 8, 2026
Merged

adamtheturtle merged 4 commits into
mainfrom
unused-ignore-error

Conversation

@adamtheturtle

@adamtheturtle adamtheturtle commented Sep 7, 2026

Copy link
Copy Markdown
Member

Switches the pyrefly config to preset = "strict" (see https://pyrefly.org/en/docs/configuration/). Strict enables unused-ignore, so stale # pyrefly: ignore comments fail the check, along with implicit-any, missing-override-decorator and others. Any new errors from the stricter checks are fixed in this PR. Same change as VWS-Python/vws-python-mock#3567.

🤖 Generated with Claude Code

Pyrefly's unused-ignore rule is silent by default, so stale
`# pyrefly: ignore` comments go unnoticed after upgrades.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
The strict preset enables unused-ignore along with implicit-any,
missing-override-decorator and other checks.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@adamtheturtle adamtheturtle changed the title Make pyrefly error on unused ignore comments Use the pyrefly strict preset Sep 7, 2026
Vulture reports decorated methods at the decorator's line, so the
noqa comments must move up with the new @OverRide decorators.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@adamtheturtle
adamtheturtle merged commit 42af7c0 into main Sep 8, 2026
34 of 36 checks passed
@adamtheturtle
adamtheturtle deleted the unused-ignore-error branch September 8, 2026 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant