Make pyrefly error on unused ignore comments - #2570
Merged
Merged
Conversation
Pyrefly's unused-ignore rule is silent by default, so stale `# pyrefly: ignore` comments go unnoticed after upgrades. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
September 7, 2026 21:39 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets
errors.unused-ignore = "error"in the pyrefly config. This rule is silent by default (not even a warning), so# pyrefly: ignorecomments that no longer suppress anything go unnoticed after pyrefly upgrades. Same change as VWS-Python/vws-python-mock#3567.🤖 Generated with Claude Code