docs(verifier): say os_image_is_dev is only reported on the TDX legacy path - #1266
Merged
Merged
Conversation
This was referenced Sep 20, 2026
kvinwang
force-pushed
the
fix/verifier-result-contract
branch
from
September 24, 2026 08:41
456a5d3 to
ee42885
Compare
kvinwang
force-pushed
the
fix/verifier-result-contract
branch
from
September 24, 2026 09:02
ee42885 to
4adaff2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
verifier/README.mdtold relying parties to reject dev images viaos_image_is_dev, and said it isnullonly on GCP TDX and Nitro Enclave. In fact the only assignment is on the TDX legacy path (the only path that downloads the image and readsmetadata.json). TDX lite, SEV-SNP, GCP TDX, AWS NitroTPM and Nitro Enclave carry only the manifest digest, so the field is alwaysnullthere, and a "reject ifos_image_is_dev == true" policy accepts every dev image on those paths. The README also did not say thatis_validignorestcb_status.Fix
Docs only: state where
os_image_is_dev/os_image_versionare reported, tell relying parties to allowlistos_image_hashinstead, and note thattcb_statusis surfaced, not gated (linking the existing security-model section).Verification
cargo test -p dstack-verifier, fmt and clippy clean (no code change beyond doc comments).The measurement-cache bound from the original PR is #1369, and the
report_datadomain-tag section is #1370.