fix(verifier): bound the measurement cache directory - #1369
Merged
Merged
Conversation
kvinwang
force-pushed
the
fix/verifier-measurement-cache-bound
branch
from
September 24, 2026 09:00
1af2881 to
0e7de76
Compare
kvinwang
added a commit
that referenced
this pull request
Sep 25, 2026
…bounds #1251 renamed the manifest confinement test the image-download case ran by name. Run its replacement plus the tests that pin the sha256sum grammar, the end-to-end image binding (#1337) and the truncated-download retry (#1388), and extend the measurement cache case with shape-only keying (#1334) and the bounded cache directory (#1369). Signed-off-by: Kevin Wang <wy721@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1266.
Problem
store_measurements_in_cachewrites one file per VM shape under<image_cache_dir>/measurements/and nothing ever removes them, including entries whose measurements then failed to match the quote. A caller with any valid quote can vary the shape and grow the directory without limit (slowly: each entry costs a full image measurement).Fix
Cap the directory at
MEASUREMENT_CACHE_MAX_ENTRIES = 1024(~400 B each). After each store, drop the oldest.jsonentries by mtime; in-flightNamedTempFiles have no extension and are left alone. Pruning is best effort and never fails a verification. A cap, not a TTL: a shape always yields the same measurements.Verification
cargo test -p dstack-verifier(36 passed, includingmeasurement_cache_evicts_the_oldest_entries_and_spares_temporaries), fmt and clippy clean. Merges cleanly with #1337.