Repository navigation
docs(security): say what a report_data domain tag does and does not prove - #1370
Merged
Merged
Conversation
kvinwang
force-pushed
the
docs/report-data-domain-tags
branch
from
September 24, 2026 09:03
38bf661 to
53427d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out of #1266.
Problem
An audit claim: an app can mint a quote with
report_data = sha512("ratls-cert:" || <any SPKI>)and so forge an RA-TLS key-possession proof. It does not break dstack (quote identity comes from the system-owned RTMR3 log, and every in-tree consumer ofratls-cert:also forces use of the key:ra-rpcchecks the completed handshake's key, and the KMS verifies the CSR signature beforeverify_with_ra_pubkey). But nothing told external relying parties they must do the same.Fix
Docs only: a short
security-model.mdsection sayingreport_datadomain tags are a parsing convention, not a capability, and a verification-checklist item to tie a key binding to a live handshake or signature.Verification
Claims checked against
guest-agent/src/rpc_service.rs(tdx_quoteprefix →QuoteContentType::Custom) andkms/src/main_service.rs(CSR signature checked beforeverify_with_ra_pubkey).