Skip to content

test(cli): redact bun build hash in snapshots #2514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 2 commits into from
Aug 21, 2026
Merged

test(cli): redact bun build hash in snapshots #2514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb4b73
test(cli): redact bun build hash in snapshots
jong-kyung Aug 20, 2026
4620ed0
test(cli): require bun banner context for build hash redaction
jong-kyung Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ...shots/tests/cli_snapshots/fixtures/command_add_bun/snapshots/command_add_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ For more information, try '--help'.
should add package as dev dependencies

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed testnpm2@1.0.1

Expand All @@ -80,7 +80,7 @@ installed testnpm2@1.0.1
should add packages to dependencies

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed testnpm2@1.0.1
installed test-vite-plus-install@1.0.0
Expand Down Expand Up @@ -111,7 +111,7 @@ should install package alias for add
```
VITE+ - The Unified Toolchain for the Web

bun add <version> (af24e281)
bun add <version> (<hash>)

installed test-vite-plus-package@1.0.0

Expand Down Expand Up @@ -142,7 +142,7 @@ installed test-vite-plus-package@1.0.0
should add package as optional dependencies

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed test-vite-plus-package-optional@1.0.0

Expand Down
2 changes: 1 addition & 1 deletion ...ots/tests/cli_snapshots/fixtures/command_list_bun/snapshots/command_list_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ should install packages first
```
VITE+ - The Unified Toolchain for the Web

bun install <version> (af24e281)
bun install <version> (<hash>)

test-vite-plus-package@1.0.0
test-vite-plus-package-optional@1.0.0
Expand Down
6 changes: 3 additions & 3 deletions ...s/cli_snapshots/fixtures/command_outdated_bun/snapshots/command_outdated_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ should install packages first
```
VITE+ - The Unified Toolchain for the Web

bun install <version> (af24e281)
bun install <version> (<hash>)

test-vite-plus-top-package@1.0.0 (<version> available)
test-vite-plus-other-optional@1.0.0 (<version> available)
Expand All @@ -54,7 +54,7 @@ bun install <version> (af24e281)
should show outdated package

```
bun outdated <version> (af24e281)
bun outdated <version> (<hash>)
┌──────────┬─────────┬────────┬────────┐
│ Package │ Current │ Update │ Latest │
├──────────┼─────────┼────────┼────────┤
Expand All @@ -67,7 +67,7 @@ bun outdated <version> (af24e281)
should support recursive output

```
bun outdated <version> (af24e281)
bun outdated <version> (<hash>)
┌──────────────────────────────────────────┬─────────┬────────┬────────┬──────────────────────┐
│ Package │ Current │ Update │ Latest │ Workspace │
├──────────────────────────────────────────┼─────────┼────────┼────────┼──────────────────────┤
Expand Down
2 changes: 1 addition & 1 deletion ...xtures/command_pm_approve_builds_bun/snapshots/command_pm_approve_builds_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ forwards bun pm trust --all (errors on empty project — no lockfile)
**Exit code:** 1

```
bun pm trust <version> (af24e281)
bun pm trust <version> (<hash>)
error: Lockfile not found
```
12 changes: 6 additions & 6 deletions ...tests/cli_snapshots/fixtures/command_remove_bun/snapshots/command_remove_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ For more information, try '--help'.
should error when remove not exists package from dev dependencies

```
bun remove <version> (af24e281)
bun remove <version> (<hash>)
package.json doesn't have dependencies, there's nothing to remove!
```

Expand All @@ -68,7 +68,7 @@ package.json doesn't have dependencies, there's nothing to remove!
should add packages to dependencies

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed testnpm2@1.0.1

Expand All @@ -78,7 +78,7 @@ installed testnpm2@1.0.1
## `vp add -D test-vite-plus-install`

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed test-vite-plus-install@1.0.0

Expand All @@ -88,7 +88,7 @@ installed test-vite-plus-install@1.0.0
## `vp add -O test-vite-plus-package-optional`

```
bun add <version> (af24e281)
bun add <version> (<hash>)

installed test-vite-plus-package-optional@1.0.0

Expand Down Expand Up @@ -119,7 +119,7 @@ installed test-vite-plus-package-optional@1.0.0
should remove packages from dependencies

```
bun remove <version> (af24e281)
bun remove <version> (<hash>)

- testnpm2
- test-vite-plus-install
Expand All @@ -144,7 +144,7 @@ bun remove <version> (af24e281)
should remove package from optional dependencies

```
bun remove <version> (af24e281)
bun remove <version> (<hash>)

package.json has no dependencies! Deleted empty lockfile

Expand Down
4 changes: 2 additions & 2 deletions ...tests/cli_snapshots/fixtures/command_update_bun/snapshots/command_update_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ Documentation: https://viteplus.dev/guide/install
should update package within semver range

```
bun update <version> (af24e281)
bun update <version> (<hash>)

test-vite-plus-package@1.0.0
test-vite-plus-package-optional@1.0.0
Expand Down Expand Up @@ -74,7 +74,7 @@ installed testnpm2@1.0.1
should update to absolute latest version

```
bun update <version> (af24e281)
bun update <version> (<hash>)

installed testnpm2@1.0.1

Expand Down
2 changes: 1 addition & 1 deletion ...shots/tests/cli_snapshots/fixtures/command_why_bun/snapshots/command_why_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ should install packages first
```
VITE+ - The Unified Toolchain for the Web

bun install <version> (af24e281)
bun install <version> (<hash>)

test-vite-plus-package@1.0.0
test-vite-plus-package-optional@1.0.0
Expand Down
2 changes: 1 addition & 1 deletion ...shots/fixtures/create_approve_builds_bun/snapshots/create_approve_builds_bun.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ no trustedDependencies, the build was not run
the guidance's `vp pm approve-builds` command approves the gated build

```
bun pm trust <version> (0d9b296a)
bun pm trust <version> (<hash>)

./node_modules/core-js @3.39.0
✓ [postinstall]: node -e "try{require('./postinstall')}catch(e){}"
Expand Down
12 changes: 12 additions & 0 deletions crates/vp_cli_snapshots/tests/cli_snapshots/redact.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ static TOOL_VERSION_RE: LazyLock<regex::Regex> = LazyLock::new(|| {
)
.unwrap()
});
// bun banners append the build's short commit hash after the version
// ("bun pm trust v1.4.0 (34cbb9a40)"), which changes with every bun release.
// The version is already masked to `<version>` by the passes above; require
// the leading `bun <subcommand>` context so version-plus-hash lines from
// other tools stay assertable.
static BUN_BUILD_HASH_RE: LazyLock<regex::Regex> = LazyLock::new(|| {
regex::Regex::new(r"(\bbun(?: [a-z-]+)* <version> )\([0-9a-f]{6,12}\)").unwrap()
});
// The workspace's own vite-plus / @voidzero-dev/vite-plus-core version is
// written verbatim into scaffolded catalogs and manifests (`vite-plus: 0.2.3`,
// `"vite-plus": "0.2.3"`, `npm:@voidzero-dev/vite-plus-core@0.2.3`). Unlike
Expand Down Expand Up @@ -429,6 +437,10 @@ pub fn redact_output(
// Redact bare runtime-tool versions by name context (see TOOL_VERSION_RE)
output = TOOL_VERSION_RE.replace_all(&output, "$1$2<version>").into_owned();

// Redact bun's build hash next to an already-masked version
// (see BUN_BUILD_HASH_RE), which changes with every bun release.
output = BUN_BUILD_HASH_RE.replace_all(&output, "$1(<hash>)").into_owned();

// Redact the workspace's own vite-plus/core version by package context
// (see VP_VERSION_RE), which bumps on every release.
output = VP_VERSION_RE.replace_all(&output, "${1}<version>").into_owned();
Expand Down
11 changes: 11 additions & 0 deletions crates/vp_cli_snapshots/tests/redact_unit.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,17 @@ fn masks_bare_runtime_tool_versions_by_name_context() {
);
}

#[test]
fn masks_bun_build_hash_only_in_bun_banners() {
// bun banners append the build's short commit hash after the version,
// which changes with every bun release.
let input = "bun pm trust v1.4.0 (34cbb9a40)\n".to_owned();
assert_eq!(redact_output(input, &[], true), "bun pm trust <version> (<hash>)\n");
// Parenthesized hex without a preceding masked version stays verbatim.
let unrelated = "commit (deadbeef1) applied\n".to_owned();
assert_eq!(redact_output(unrelated.clone(), &[], true), unrelated);
}

#[test]
fn masks_managed_node_versions_in_environment_output() {
let input = concat!(
Expand Down
Loading