test(cli): redact bun build hash in snapshots - #2514
Conversation
bun banners append the build's short commit hash after the version
("bun pm trust v1.4.0 (34cbb9a40)"), and the hash changes with every
bun release. The version was already masked, but the hash was recorded
verbatim, so snapshots of fixtures that follow the latest bun broke
whenever bun shipped a release, as create_approve_builds_bun did when
bun 1.4.0 came out.
Mask the hash as <hash>, anchored on the already-masked <version>
token so parenthesized hex elsewhere stays assertable, and re-record
the eight bun snapshots that embedded a hash. A full-suite re-record
confirmed no other snapshot is affected.
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: aeb4b73dd5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Anchoring only on the masked version token would also mask a version-plus-hash line printed by any other tool; require the leading bun subcommand context so those stay assertable.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
bun banners append the build's short commit hash after the version ("bun pm trust v1.4.0 (34cbb9a40)"), and the hash changes with every bun release. The version was already masked, but the hash was recorded verbatim, so snapshots of fixtures that follow the latest bun broke whenever bun shipped a release, as create_approve_builds_bun did when bun 1.4.0 came out.
Ref: #2513 CI Failure