Skip to content

Pre-planning cup grabbing - #232

Closed
Yao Chen (yao-stuy) wants to merge 0 commit into
viamrobotics:mainfrom
yao-stuy:main
Closed

Pre-planning cup grabbing#232
Yao Chen (yao-stuy) wants to merge 0 commit into
viamrobotics:mainfrom
yao-stuy:main

Conversation

@yao-stuy

Copy link
Copy Markdown
Member

Dynamic cup/glass pickup used to discover unreachable candidates by physically
reaching for them — approach, find the grab descent unplannable, retreat — wasting
a full reach-and-back-out per bad candidate.

tryGrab now plans both the approach and grab descent up front without moving. An
unreachable candidate is skipped with the arm still parked at the observe pose;
only a candidate whose legs both plan is grabbed, and the validated plans are
executed directly instead of re-planned.

The grab sequence is otherwise unchanged (approach → open → descend → verify →
attach → retreat), and grabAndVerifyHolding remains the backstop that a cup was
actually picked up. Implemented by splitting moveToRawPose into planRawPose +
executePlan; existing callers are unaffected.

🤖 Generated with Claude Code

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up the comments a little? claude added a lot of comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants