Pre-planning cup grabbing - #232
Closed
Yao Chen (yao-stuy) wants to merge 0 commit into
Closed
Conversation
Nicolas Palpacuer (NickPPC)
left a comment
Member
There was a problem hiding this comment.
Can you clean up the comments a little? claude added a lot of comments.
Yao Chen (yao-stuy)
force-pushed
the
main
branch
from
July 15, 2026 17:35
79ac9ac to
31fb6fd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dynamic cup/glass pickup used to discover unreachable candidates by physically
reaching for them — approach, find the grab descent unplannable, retreat — wasting
a full reach-and-back-out per bad candidate.
tryGrabnow plans both the approach and grab descent up front without moving. Anunreachable candidate is skipped with the arm still parked at the observe pose;
only a candidate whose legs both plan is grabbed, and the validated plans are
executed directly instead of re-planned.
The grab sequence is otherwise unchanged (approach → open → descend → verify →
attach → retreat), and
grabAndVerifyHoldingremains the backstop that a cup wasactually picked up. Implemented by splitting
moveToRawPoseintoplanRawPose+executePlan; existing callers are unaffected.🤖 Generated with Claude Code