Skip to content

chore(CI): Fix smoke test - #268

Merged
mtodor merged 1 commit into
mainfrom
mtodor/fix-smoke-test
Oct 8, 2026
Merged

mtodor merged 1 commit into
mainfrom
mtodor/fix-smoke-test

Conversation

@mtodor

@mtodor mtodor commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Description

This PR fixes health check for smoke tests. How overall health is calculated is changed and for smoke test, only sensor access is relevant.

Validation

  • let CI pipeline run smoke test

@mtodor
mtodor requested a review from janisz as a code owner October 8, 2026 13:46
@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: 76226ace-a364-4d29-91f9-0168df8c7c8d
📥 Commits

Reviewing files that changed from the base of the PR and between a09dfbd and c4c087c.

📒 Files selected for processing (1)
  • smoke/central_helper_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Cluster health checks now use the sensor health status. A cluster is reported as healthy only when its sensor status is exactly “HEALTHY.”

Walkthrough

The cluster health response now uses sensorHealthStatus. IsClusterHealthy returns a healthy result when the first cluster’s sensor health status is exactly "HEALTHY".

Changes

Cluster health status

Layer / File(s) Summary
Read sensor health status
smoke/central_helper_test.go
The health response field uses the sensorHealthStatus JSON key. IsClusterHealthy checks the first cluster’s sensor health status for an exact "HEALTHY" match.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c4c08

The smoke check now reads the sensor-specific health status exposed by the endpoint. No actionable merge risk is established.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description explains that the smoke test health check now uses sensor access as the relevant health measure. It is related to the changeset.
Title check ✅ Passed The title clearly identifies the primary change: fixing the smoke test in CI.
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

E2E Test Results

Commit: c4c087c
Workflow Run: View Details
Artifacts: Download test results & logs

=== Evaluation Summary ===

  ✓ cve-cluster-does-exist (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)
  ✓ list-clusters (assertions: 3/3)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ cve-cluster-does-not-exist (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ~ cve-nonexistent (assertions: 2/3)
      - MaxToolCalls: Too many tool calls: expected <= 5, got 8
  ✓ cve-detected-clusters (assertions: 3/3)

Tasks:      11/11 passed (100.00%)
Assertions: 31/32 passed (96.88%)
Tokens:     ~72053 (estimate - excludes system prompt & cache)
MCP schemas: ~12562 (included in token total)
Agent used tokens:
  Input:  18746 tokens
  Output: 26939 tokens
Judge used tokens:
  Input:  30978 tokens
  Output: 30329 tokens

@codecov-commenter

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
380 2 378 12
View the full list of 2 ❄️ flaky test(s)
::policy 1

Flake rate in main: 100.00% (Passed 0 times, Failed 166 times)

Stack Traces | 0s run time
- test violation 1
- test violation 2
- test violation 3
::policy 4

Flake rate in main: 100.00% (Passed 0 times, Failed 166 times)

Stack Traces | 0s run time
- testing multiple alert violation messages 1
- testing multiple alert violation messages 2
- testing multiple alert violation messages 3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@mtodor
mtodor merged commit 66c9a63 into main Oct 8, 2026
10 checks passed
@mtodor
mtodor deleted the mtodor/fix-smoke-test branch October 8, 2026 15:23
@mtodor mtodor mentioned this pull request Oct 8, 2026
1 task done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants