Skip to content

chore(CI): Backport Fix smoke test - #269

Merged
mtodor merged 1 commit into
release-0.2from
mtodor/fix-smoke-test-backport-release-0-2
Oct 9, 2026
Merged

mtodor merged 1 commit into
release-0.2from
mtodor/fix-smoke-test-backport-release-0-2

Conversation

@mtodor

@mtodor mtodor commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Backport #268

Validation

  • let CI run it

@mtodor
mtodor requested a review from janisz as a code owner October 8, 2026 15:26
@mtodor mtodor changed the title chore(CI): Fix smoke test chore(CI): Backport Fix smoke test Oct 8, 2026
@codecov-commenter

codecov-commenter commented Oct 8, 2026 •

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
380 2 378 12
View the full list of 2 ❄️ flaky test(s)
::policy 1

Flake rate in main: 100.00% (Passed 0 times, Failed 168 times)

Stack Traces | 0s run time
- test violation 1
- test violation 2
- test violation 3
::policy 4

Flake rate in main: 100.00% (Passed 0 times, Failed 168 times)

Stack Traces | 0s run time
- testing multiple alert violation messages 1
- testing multiple alert violation messages 2
- testing multiple alert violation messages 3

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
  • Review profile: ASSERTIVE
  • Plan: Enterprise
  • Run ID: 527d04c4-8bf3-46f3-b66c-7e8a127f00ad

📥 Commits

Reviewing files that changed from the base of the PR and between b4c8ff0 and 35a4e55.


📒 Files selected for processing (1)
  • smoke/central_helper_test.go

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.



📝 Summary

Summary by CodeRabbit

  • Bug Fixes
    • Cluster health checks now recognize a cluster as healthy when its sensor health status is “HEALTHY.” This corrects health assessments when the sensor status differs from the overall health status, helping ensure that health-check results reflect the sensor status used to determine cluster health. No other user-facing behavior changes are included in this release.

Walkthrough

The cluster health response maps sensorHealthStatus. IsClusterHealthy checks whether the first cluster’s sensor health status is "HEALTHY".

Changes

Cluster health check

Layer / File(s) Summary
Read sensor health status
smoke/central_helper_test.go
The response field maps to sensorHealthStatus. IsClusterHealthy checks that field for "HEALTHY".

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix


Merge Risk: ⚪ Minimal · up to 35a4e

No merge-blocking behavior is established in the changed smoke-test readiness check.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Title check Passed The title identifies the CI smoke test fix and states that it is a backport. This matches the changeset.
Description check Passed The description states that the change backports issue #268 and includes CI validation. This relates to the smoke test fix.


✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR

🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR



Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown

E2E Test Results

Commit: 35a4e55
Workflow Run: View Details
Artifacts: Download test results & logs

=== Evaluation Summary ===

  ✓ cve-cluster-does-exist (assertions: 3/3)
  ✓ list-clusters (assertions: 3/3)
  ✓ rhsa-not-supported (assertions: 2/2)
  ✓ cve-detected-workloads (assertions: 3/3)
  ✓ cve-log4shell (assertions: 3/3)
  ✓ cve-detected-clusters (assertions: 3/3)
  ✓ cve-cluster-list (assertions: 3/3)
  ✓ cve-multiple (assertions: 3/3)
  ✓ cve-clusters-general (assertions: 3/3)
  ✓ cve-cluster-does-not-exist (assertions: 3/3)
  ✓ cve-nonexistent (assertions: 3/3)

Tasks:      11/11 passed (100.00%)
Assertions: 32/32 passed (100.00%)
Tokens:     ~57517 (estimate - excludes system prompt & cache)
MCP schemas: ~12562 (included in token total)
Agent used tokens:
  Input:  7558 tokens
  Output: 21287 tokens
Judge used tokens:
  Input:  47771 tokens
  Output: 37140 tokens

@mtodor
mtodor merged commit 5358c73 into release-0.2 Oct 9, 2026
10 checks passed
@mtodor
mtodor deleted the mtodor/fix-smoke-test-backport-release-0-2 branch October 9, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants