Activity redesign 1/8: resolve change subjects server-side and generate the change-type list by myieye · Pull Request #2435 · sillsdev/languageforge-lexbox

myieye · 2026-07-12T12:51:31Z

Part 1 of 8 of the activity redesign (readable summaries + before/after diffs, #2170). The full assembled result of parts 1–6 — reviewed end-to-end by CodeRabbit and verified green — lived in #2434 (now closed); it was too large to merge in one piece, so it's split into a stacked sequence where each part is independently green and reviewable. This PR is the only one open; each next part gets its PR when its predecessor merges.

The sequence (each branch builds on the previous; part 6's tree is byte-identical to the reviewed #2434 head):

claude/activity-1-backend-change-info (this PR) — backend enrichment + change-type codegen. No user-visible change.
claude/activity-2-ws-code-chips — writing-system codes render as monospace chips app-wide (editor field labels, dictionary preview) for parity with the upcoming read-only diffs.
claude/activity-3-diff-components — the read-only diff-view component library (field-level before/after, inline text diff via @sanity/diff-match-patch, audio diffs) + storybook gallery + field-coverage guard tests. No consumer yet.
claude/activity-4-list-summaries — the activity list rows become readable summaries ("Apfel › apple · Set Definition (en) to …") grouped by entry, with per-author colours, badges, and bulk-create collapsing; exhaustiveness tests fail if a new change type lacks a summary.
claude/activity-5-detail-previews — the detail panel renders real before/after diffs through the diff components; single-entry create commits collapse to an assembled read-only view; per-card failure containment.
claude/activity-6-list-detail-layout — extracts Browse's responsive list↔detail shell into a shared ListDetailLayout and adopts it in Activity: resizable split panes on desktop, full-width list on mobile with full-screen detail + back-button support.
claude/activity-7-change-type-filter — replaces the flat ~65-row activity-type multi-select with a grouped, searchable, tri-state filter (sections by what a change touches, collapsed by default, hover "Only" shortcuts, empty selection = unfiltered, debounced instant apply).
claude/activity-8-author-filter — unifies the author facet onto the same shell and semantics (shared FacetFilter component, empty = unfiltered, ×-clear, "Only"), deleting the old 'all'-sentinel machinery and the "No authors → empty feed" state.

UI previews for the filter parts (7 and 8) — open in a browser:

https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/ff896559192ae3bb4f406ecde6272963a5de1142/docs/img/pr-activity-filter/filter-collapsed-groups.png
https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/ff896559192ae3bb4f406ecde6272963a5de1142/docs/img/pr-activity-filter/filter-group-expanded.png
https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/ff896559192ae3bb4f406ecde6272963a5de1142/docs/img/pr-activity-filter/filter-active-trigger.png
https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/38e5b4fb8369f730a83ce0d1e9c3e7c58b80eff1/docs/img/pr-activity-filter/filter-bar-unified.png
https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/38e5b4fb8369f730a83ce0d1e9c3e7c58b80eff1/docs/img/pr-activity-filter/author-filter-open.png
https://raw.githubusercontent.com/sillsdev/languageforge-lexbox/38e5b4fb8369f730a83ce0d1e9c3e7c58b80eff1/docs/img/pr-activity-filter/author-filter-active.png

This part

Adds ActivityChangeInfoResolver: one batched pass per activity page that labels each change with the entity it's about (entry headword with homograph subscript, "headword › gloss" for senses, vocab object names), any item the change references only by id (the part of speech set, the semantic domain removed, the component linked), and the change's root entry so the frontend can group a commit's changes. Deleted objects are recovered from their latest snapshot (one Take(1) query per missing id) so a delete can still name its subject. ProjectActivity returns a materialized page (Task<ProjectActivity[]>) of enriched record copies (ChangeInfo is init-only) since the resolver batch-loads across the page — every consumer already materialized.

ChangeContext gains PreviousSnapshot (the entity's state just before the commit), the data needed for true before/after diffs (#2170).

A Reinforced.Typings generator emits a ChangeType string-literal union + knownChangeTypes array from the registered CRDT change types, using the same discriminator helper the runtime uses — parts 4 and 7's coverage tests are built on it, so a new change type can't silently ship without a summary or a filter group.

Tests: HistoryServiceActivityTests covers subject/target naming (homograph only-when-assigned, morph-type markers, sense numbering, deleted-object recovery, component endpoints, reorders) — 36 tests, all passing. Frontend impact is limited to regenerated types (additive) and a one-line HistoryView fix for the new required changeInfo property.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Vm9mEUzcfgX4oUPAbhcfsj

…type list Adds ActivityChangeInfoResolver: one batched pass per activity page that labels each change with the entity it's about (entry headword with homograph subscript, 'headword › gloss' for senses, vocab object names), the referenced item it names only by id (part of speech set, semantic domain removed, component linked), and the root entry so the frontend can group a commit's changes. Deleted objects are recovered from their latest snapshot so a delete can still name its subject. ProjectActivity returns a materialized page (Task<ProjectActivity[]>) of enriched record copies since the resolver batch-loads across it. ChangeContext gains PreviousSnapshot (the entity's state just before the commit) so the frontend can render true before/after diffs (#2170). A Reinforced.Typings generator emits a ChangeType union + knownChangeTypes array from the registered CRDT change types via the same discriminator helper the runtime uses, giving the frontend a generated, exhaustive list to guard summary coverage with. Part 1/6 of the activity redesign (#2434 shows the assembled result). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vm9mEUzcfgX4oUPAbhcfsj

coderabbitai · 2026-07-12T12:51:38Z

📝 Walkthrough

Walkthrough

Changes

Project activity now returns materialized pages enriched with resolved subjects and targets. Backend context handling, generated TypeScript contracts, invokable callers, viewer data construction, and extensive naming tests were updated accordingly.

Project Activity Enrichment

Layer / File(s)	Summary
Activity contract and batch resolution `backend/FwLite/LcmCrdt/HistoryService.cs`	`ProjectActivity` returns enriched arrays, `ChangeContext` tracks previous snapshots, and change-type key lookup is public.
Change-info label resolution `backend/FwLite/LcmCrdt/ActivityChangeInfoResolver.cs`	Loads current or recovered entities and resolves subjects, targets, headwords, sense labels, reorder metadata, and component endpoints.
Generated frontend contracts `backend/FwLite/FwLiteShared/TypeGen/`, `frontend/viewer/src/lib/dotnet-types/generated-types/LcmCrdt/`	Generates activity metadata interfaces and a complete `ChangeType` union with its known-value array.
Callers and validation `backend/FwLite/FwLiteShared/Services/HistoryServiceJsInvokable.cs`, `backend/FwLite/LcmCrdt.Tests/*`, `frontend/viewer/src/lib/history/HistoryView.svelte`	Updates callers and tests for materialized results and adds coverage for change-info naming across change scenarios.

Estimated code review effort: 4 (Complex) | ~45 minutes

Possibly related PRs

sillsdev/languageforge-lexbox#1804: Changes the execution and materialization model of HistoryService.ProjectActivity.
sillsdev/languageforge-lexbox#2093: Extends activity change-context handling.
sillsdev/languageforge-lexbox#2357: Updates the activity querying surface and filters.

Suggested reviewers: rmunn, hahn-kev

Poem

I hop through changes, neat and bright,
With labels blooming into sight.
Old snapshots found, new types agree,
A tidy trail for history.
The rabbit stamps: “Enriched—whee!”

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 15.28% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly summarizes the main backend change and generated change-type list.
Description check	✅ Passed	The description directly matches the PR's backend enrichment and change-type generation work.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/activity-1-backend-change-info

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

argos-ci · 2026-07-12T12:54:25Z

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Jul 12, 2026, 12:54 PM
e2e (Inspect)	⚠️ Changes detected (Review)	5 changed	Jul 12, 2026, 1:01 PM

myieye · 2026-07-12T13:02:18Z

Note for the Argos review: this part is backend-only and intends zero visual change — the deterministic default build agrees (✅ no changes detected). The 5 diffs on the e2e build should therefore be environment noise (the e2e suite screenshots live pages with relative timestamps/seeded data, and it has flagged diffs on every recent build regardless of branch). If any of the 5 shows a real content difference rather than timestamp/data churn, please flag it here — that would mean the enriched activity payload is affecting the current UI, which would be a bug in this part.

Generated by Claude Code

myieye · 2026-07-12T15:29:19Z

@coderabbitai review

Generated by Claude Code

coderabbitai · 2026-07-12T15:29:32Z

@myieye: Got it, I'll review the changes now.

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jul 12, 2026

This was referenced Jul 12, 2026

Rework the activity view: readable summaries and a before/after diff #2388

Closed

Activity redesign: responsive split view, failure containment, review hardening (follow-on to #2388) #2434

Closed

myieye changed the title ~~Activity redesign 1/6: resolve change subjects server-side and generate the change-type list~~ Activity redesign 1/7: resolve change subjects server-side and generate the change-type list Jul 12, 2026

myieye changed the title ~~Activity redesign 1/7: resolve change subjects server-side and generate the change-type list~~ Activity redesign 1/8: resolve change subjects server-side and generate the change-type list Jul 12, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Activity redesign 1/8: resolve change subjects server-side and generate the change-type list#2435

Activity redesign 1/8: resolve change subjects server-side and generate the change-type list#2435
myieye wants to merge 1 commit into
developfrom
claude/activity-1-backend-change-info

myieye commented Jul 12, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

argos-ci Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

myieye commented Jul 12, 2026

Uh oh!

myieye commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

myieye commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

This part

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

argos-ci Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

myieye commented Jul 12, 2026

Uh oh!

myieye commented Jul 12, 2026

Uh oh!

coderabbitai Bot commented Jul 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

myieye commented Jul 12, 2026 •

edited

Loading

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading

argos-ci Bot commented Jul 12, 2026 •

edited

Loading

coderabbitai Bot commented Jul 12, 2026 •

edited

Loading