refactor: establish HTML folder feature - #327
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9604786121
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "public": [ | ||
| "CustomElementRegistry", | ||
| "Document", | ||
| "DomHTMLMediaElement", |
There was a problem hiding this comment.
Keep HTMLElement available to the DOM feature
When a consumer builds only WebAPI.DOM, this source group still compiles DomHTMLMediaElement and HTMLTrackElement, whose implementations include HTMLElement.Impl (src/DOM/DomHTMLMediaElement.res:147 and src/DOM/HTMLTrackElement.res:14). Because HTMLElement was moved behind the separate HTML feature and WebAPI.DOM does not enable it, that previously valid feature-only build now fails with an unresolved module; keep the base module in the DOM slice until these media interfaces move, or otherwise ensure the slice includes their dependency.
Useful? React with 👍 / 👎.
9604786 to
b9e476c
Compare
Tracking issue: #342
Stack context
Part 17 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #326.
Summary
src/htmlfolder on the unqualified internalHTMLfeatureWebAPI.HTML -> WebAPI.DOMNodes + WebAPI.File + HTMLfeatureHTMLUnknownElementinterface publiclyMedia boundary
DomHTMLMediaElement,HTMLAudioElement,HTMLTrackElement, andHTMLVideoElementremain for the next Media layer. Their APIs directly reference Remote Playback, Picture-in-Picture, WebVTT, media-error, time-range, and playback-quality types. Moving them here would create anHTML <-> Mediacycle because Media already depends on HTML.Temporary state
HTML.resis received transitively from DOMNodes because Element and ShadowRoot require its serialization/shadow-root optionsReview focus
WebAPI.HTMLdependency closureHTMLUnknownElementVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTMLnpm run buildnpm testnpm run format:checkgit diff --check