refactor: establish Media folder feature - #328
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30bae3badc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/MediaCapabilities", | ||
| "dir": "src/media", |
There was a problem hiding this comment.
Register the media source with documentation generators
When documentation generation processes a public file under the new src/media directory, docs/llm.js cannot find its directory in featureSpecs and throws Unsupported source directory for documentation; similarly, docs/utils.js only creates API routes for a recognized feature directory containing its expected *Types.res, so the APIs moved here disappear from the generated site. Update the documentation feature mapping/generation logic as part of this consolidation so it understands the new Media grouping.
Useful? React with 👍 / 👎.
30bae3b to
a26ff7e
Compare
Tracking issue: #342
Stack context
Part 18 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #327.
Summary
src/mediafolder on the unqualified internalMediafeatureWebAPI.Media -> WebAPI.HTML + MediafeatureBaseEncryptedMediaExtensionsout of the foundational coreMediaError,VideoPlaybackQuality, and the consolidated media interfaces throughWebAPI.MediaTemporary state
Navigatorremains in the legacy DOM folder and references Media-owned types; its broad cross-domain surface is resolved in the later Navigator integration PRDocumentremains in the legacy DOM folder even though it contains Picture-in-Picture operations; it moves with the later Window/document integration layerWebAPI.DOMsource entry remains until its remaining interfaces have been assignedReview focus
WebAPI.Mediadependency closureVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,DOMPlatform,Animation,CSSOM,Geometry,DOMNodes,File,HTML,Medianpm run buildnpm testnpm run format:checkgit diff --check