refactor: establish Fetch folder feature - #319
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 018501b7c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| }, | ||
| { | ||
| "dir": "src/Fetch", | ||
| "dir": "src/fetch", |
There was a problem hiding this comment.
Update Fetch's documentation lookup after moving the folder
When the API docs are generated, docs/utils.js derives each source directory from featureSpecs, where Fetch is still recorded as Fetch, so it probes src/Fetch/FetchTypes.res. After this change moves the source to src/fetch, the existsSync filter silently removes Fetch from apiModules, causing the generated API index and routes to omit the entire Fetch API. Update the shared feature metadata or documentation discovery to use the new path.
Useful? React with 👍 / 👎.
018501b to
b4415cf
Compare
Tracking issue: #342
Stack context
Part 9 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #318.
Summary
src/Fetchto the targetsrc/fetchfolderFetchfeatureWebAPI.Fetchdependency closure through Event, File, and URLThe internal
FetchTypeshelper remains private within the folder.Temporary state
Review focus
WebAPI.Fetchimplication and public module pathsVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,File,URL,Fetchnpm run buildnpm testnpm run format:checkgit diff --check