Skip to content

refactor: establish Fetch folder feature - #319

Open
jderochervlk wants to merge 1 commit into
codex/option5-css-font-loading-folderfrom
codex/option5-fetch-folder
Open

refactor: establish Fetch folder feature#319
jderochervlk wants to merge 1 commit into
codex/option5-css-font-loading-folderfrom
codex/option5-fetch-folder

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Tracking issue: #342

Stack context

Part 9 of the Option 5 folder-feature stack.

Review this PR as the incremental diff against #318.

Summary

  • rename src/Fetch to the target src/fetch folder
  • retain the complete folder on the existing unqualified internal Fetch feature
  • preserve the supported WebAPI.Fetch dependency closure through Event, File, and URL
  • leave all flat Fetch interface module paths unchanged

The internal FetchTypes helper remains private within the folder.

Temporary state

  • this PR does not introduce compatibility aliases, exclusions, or module slices; the Fetch folder and feature ownership are final
  • the File dependency is still backed by the pre-consolidation File folders and core helpers; the next layer completes that ownership

Review focus

  • physical folder ownership only
  • preservation of the existing WebAPI.Fetch implication and public module paths
  • complete folder membership

Verification

  • node_modules/.bin/rescript clean
  • node_modules/.bin/rescript build --prod --features DOM,Event,File,URL,Fetch
  • npm run build
  • npm test
  • npm run format:check
  • git diff --check

Copy link
Copy Markdown
Collaborator Author

@codex

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 018501b7c4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rescript.json
},
{
"dir": "src/Fetch",
"dir": "src/fetch",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update Fetch's documentation lookup after moving the folder

When the API docs are generated, docs/utils.js derives each source directory from featureSpecs, where Fetch is still recorded as Fetch, so it probes src/Fetch/FetchTypes.res. After this change moves the source to src/fetch, the existsSync filter silently removes Fetch from apiModules, causing the generated API index and routes to omit the entire Fetch API. Update the shared feature metadata or documentation discovery to use the new path.

Useful? React with 👍 / 👎.

@jderochervlk
jderochervlk force-pushed the codex/option5-fetch-folder branch from 018501b to b4415cf Compare August 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant