refactor: consolidate File folder feature - #320
Open
jderochervlk wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
jderochervlk
force-pushed
the
codex/option5-file-folder
branch
from
August 4, 2026 17:31
5d18c50 to
9fce765
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #342
Stack context
Part 10 of the Option 5 folder-feature stack.
Review this PR as the incremental diff against #319.
Summary
src/Fileto the targetsrc/filefolderFileListfrom the legacy DOM folder into FileBaseFileAndDirectoryEntriesout ofcoreand into FileWebAPI.FileAndDirectoryEntriessource featureWebAPI.File -> WebAPI.Event + Fileand add the merged interfaces to its public module listTemporary state
BaseFileremains incorebecauseDOM.shareDatadirectly references it; moving it here now would create aDOM -> File -> Event -> DOMcycleshareData, keep the shared Blob/File records foundational, or introduce a justified sliceFileTypesand File and Directory Entries helpers remain inside the correct folder pending cleanupReview focus
BaseFileincoreVerification
node_modules/.bin/rescript cleannode_modules/.bin/rescript build --prod --features DOM,Event,Filenpm run buildnpm testnpm run format:checkgit diff --check