Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions exir/pass_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ def _leaf_symbolic_snapshot(value: Argument) -> Any:
return scalar_snapshot

if isinstance(value, FakeTensor):
if value.constant is not None:
return None
dims = []
has_symbolic_dim = False
for dim in value.shape:
Expand Down
22 changes: 22 additions & 0 deletions exir/tests/test_pass_infra.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
from executorch.exir.passes import ScalarToTensorPass
from executorch.exir.passes.pass_registry import PassRegistry
from executorch.exir.program import to_edge
from torch._subclasses.fake_tensor import FakeTensor
from torch.export import Dim, export, ExportedProgram
from torch.export.graph_signature import InputKind, InputSpec, TensorArgument
from torch.fx.passes.infra.pass_base import PassBase, PassResult
Expand Down Expand Up @@ -513,6 +514,27 @@ def placeholder(
any(dim is not None for dim in self._symbolic_input_shape(new_input))
)

def test_export_pass_ignores_symbolic_metadata_for_constant_input(self) -> None:
graph_module = self._export_dynamic_graph_module()
original_input = self._find_input_node(graph_module)
original_value = original_input.meta["val"]
self.assertIsInstance(original_value, FakeTensor)
assert isinstance(original_value, FakeTensor)
constant = torch.randn(2, 3)
original_value.constant = constant

new_graph_module = ExportPass()(graph_module).graph_module
new_input = self._find_input_node(new_graph_module)
new_value = new_input.meta["val"]

self.assertIsInstance(new_value, FakeTensor)
assert isinstance(new_value, FakeTensor)
self.assertIs(new_value.constant, constant)
self.assertEqual(
self._symbolic_input_shape(new_input),
self._symbolic_input_shape(original_input),
)

def test_export_pass_rejects_collapsed_symbolic_input_metadata(self) -> None:
class CollapseSymbolicInputPass(ExportPass):
def placeholder(
Expand Down
Loading