Ignore symbolic metadata for lifted constants (#22056) - #22056
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22056
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled JobAs of commit 325a290 with merge base 3c70c37 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117081177. |
This PR needs a
|
Summary: D116957343 began lifting `get_attr` tensor constants after edge transforms. Constant-backed `FakeTensor` values can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure. Exclude constant-backed `FakeTensor` values from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs. Reviewed By: shoumikhin Differential Revision: D117081177
47a6ace to
325a290
Compare
Summary: D116957343 began lifting `get_attr` tensor constants after edge transforms. Constant-backed `FakeTensor` values can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure. Exclude constant-backed `FakeTensor` values from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs. Reviewed By: shoumikhin Differential Revision: D117081177
325a290 to
213c547
Compare
Summary:
D116957343 began lifting
get_attrtensor constants after edge transforms. Constant-backedFakeTensorvalues can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure.Exclude constant-backed
FakeTensorvalues from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs.Reviewed By: shoumikhin
Differential Revision: D117081177