Skip to content

Ignore symbolic metadata for lifted constants (#22056) - #22056

Merged
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JacobSzwejbka:export-D117081177
Aug 24, 2026
Merged

Ignore symbolic metadata for lifted constants (#22056)#22056
meta-codesync[bot] merged 1 commit into
pytorch:mainfrom
JacobSzwejbka:export-D117081177

Conversation

@JacobSzwejbka

@JacobSzwejbka JacobSzwejbka commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Summary:

D116957343 began lifting get_attr tensor constants after edge transforms. Constant-backed FakeTensor values can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure.

Exclude constant-backed FakeTensor values from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs.

Reviewed By: shoumikhin

Differential Revision: D117081177

@pytorch-bot

pytorch-bot Bot commented Aug 22, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22056

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Cancelled Job

As of commit 325a290 with merge base 3c70c37 (image):

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 22, 2026
@meta-codesync

meta-codesync Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@JacobSzwejbka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D117081177.

@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@meta-codesync meta-codesync Bot changed the title Ignore symbolic metadata for lifted constants Ignore symbolic metadata for lifted constants (#22056) Aug 22, 2026
JacobSzwejbka added a commit to JacobSzwejbka/executorch-1 that referenced this pull request Aug 22, 2026
Summary:

D116957343 began lifting `get_attr` tensor constants after edge transforms. Constant-backed `FakeTensor` values can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure.

Exclude constant-backed `FakeTensor` values from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs.

Reviewed By: shoumikhin

Differential Revision: D117081177
Summary:

D116957343 began lifting `get_attr` tensor constants after edge transforms. Constant-backed `FakeTensor` values can retain symbolic-looking shape metadata even though pass replay uses their attached concrete constants, causing a false symbolic-input validation failure.

Exclude constant-backed `FakeTensor` values from symbolic runtime-input snapshots while retaining validation for actual symbolic inputs.

Reviewed By: shoumikhin

Differential Revision: D117081177
@meta-codesync
meta-codesync Bot merged commit b29a04a into pytorch:main Aug 24, 2026
307 of 308 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants