Skip to content

cost-onprem-chart: add 2h45m timeout to periodic e2e test - #83398

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
testetson22:adjust-cop-nightly-timeout
Aug 13, 2026
Merged

cost-onprem-chart: add 2h45m timeout to periodic e2e test#83398
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
testetson22:adjust-cop-nightly-timeout

Conversation

@testetson22

@testetson22 testetson22 commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Add 2h45m timeout to nightly main e2e tests. We were getting lucky with the default timeout. The other nightly jobs had the increased timeout.

Summary by CodeRabbit

  • Sets a 2h45m timeout for the cost-onprem-chart nightly main end-to-end test.
  • Aligns this job with other nightly jobs and prevents reliance on the default timeout.

Signed-off-by: Thomas Stetson <tstetson@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: abfa84dc-ce3f-4343-b1f1-04e27349033c

📥 Commits

Reviewing files that changed from the base of the PR and between 8a564fa and 195abea.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/insights-onprem/cost-onprem-chart/insights-onprem-cost-onprem-chart-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/insights-onprem/cost-onprem-chart/insights-onprem-cost-onprem-chart-main__periodics.yaml

Walkthrough

The nightly-main periodic test job now has a 2h45m execution timeout.

Changes

Nightly job timeout

Layer / File(s) Summary
Configure nightly-main timeout
ci-operator/config/insights-onprem/cost-onprem-chart/insights-onprem-cost-onprem-chart-main__periodics.yaml
The nightly-main job uses a 2h45m execution timeout.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Mergeability Score: ⚪ Minimal · up to 195ab

The change only adjusts the nightly end-to-end test timeout, and no actionable merge-blocking risk remains in the supplied evidence.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added 2h45m timeout for the periodic end-to-end test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only periodic job timeout fields in two YAML files; it adds no Ginkgo test titles or dynamic test-name values.
Test Structure And Quality ✅ Passed The commit changes only two CI YAML files to add a 2h45m timeout; it does not change Ginkgo tests, setup, cleanup, waits, or assertions.
Microshift Test Compatibility ✅ Passed The commit changes only two YAML timeout fields. It adds no Ginkgo tests, OpenShift API references, namespaces, or MicroShift-incompatible assumptions.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit adds only 2h45m0s timeout fields to generated CI YAML; it adds no Ginkgo e2e tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI periodic-job YAML files and adds a timeout; it does not modify deployment manifests, operators, controllers, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The pull request changes only periodic-job YAML timeout fields; it adds no OTE binary or process-level stdout write.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI timeout fields in two YAML files; it adds no Ginkgo tests or networking behavior, so this compatibility check is inapplicable.
No-Weak-Crypto ✅ Passed The HEAD diff adds only timeout: 2h45m0s in two YAML files; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or crypto implementation changes appear.
Container-Privileges ✅ Passed The parent-to-HEAD diff adds only timeout fields; it adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The commit adds only 2h45m timeout fields to two YAML files; no logging statements or sensitive data values were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from chadcrum and jordigilh August 13, 2026 16:22
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@testetson22: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-insights-onprem-cost-onprem-chart-main-periodics-nightly-main N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jordigilh, testetson22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@testetson22

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-insights-onprem-cost-onprem-chart-main-periodics-nightly-main

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@testetson22

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@testetson22: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@testetson22: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 4dd8a50 into openshift:main Aug 13, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants