[DNM]dualstack AWS debug cluster - #79562
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughAWS TechPreview jobs now use a custom release image. The AWS E2E workflow now sets an eight-hour timeout and runs ChangesAWS E2E configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Mergeability Score: ⚪ Minimal · up to The current changes present no actionable merge-blocking risk based on the supplied evidence; normal checks and review remain appropriate. Possibly related PRs
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@jechen0648, Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/openshift/e2e/aws/openshift-e2e-aws-workflow.yaml`:
- Around line 10-13: The YAML places the post block under env which breaks the
workflow; move the "post:" entry (including the "- chain: gather-core-dump"
item) out from under "env:" and place it under the job's "steps:" section as a
sibling of "pre"/"test" (so "post" is at the same level as those steps),
ensuring "TIMEOUT: +6 hours" remains under "env"; after the change run make
validate-step-registry to confirm correctness.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 8f39b93e-ab42-447b-841b-fe6a46808fc2
📒 Files selected for processing (1)
ci-operator/step-registry/openshift/e2e/aws/openshift-e2e-aws-workflow.yaml
29a43d8 to
a9ee375
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/openshift/e2e/aws/openshift-e2e-aws-workflow.yaml`:
- Around line 5-6: The env block is incorrectly placed under steps; move the
env: TIMEOUT: +6 hours entry so that env: is a top-level sibling of steps: (not
nested under any step), preserving the TIMEOUT value and ensuring the
workflow-level environment variables are defined at the workflow root; after
relocating, run make validate-step-registry to confirm the schema is valid.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 1652d1b4-1624-4407-b8f3-2a0cbd4a0bb9
📒 Files selected for processing (1)
ci-operator/step-registry/openshift/e2e/aws/openshift-e2e-aws-workflow.yaml
| env: | ||
| TIMEOUT: +6 hours |
There was a problem hiding this comment.
Move env: out of steps:; it must be a sibling to steps:.
The env: block is currently nested under steps:, which violates the step registry workflow schema. Environment variables should be defined at the workflow level, not within the steps: block.
🔧 Corrected structure
workflow:
as: openshift-e2e-aws
steps:
allow_best_effort_post_steps: true
- env:
- TIMEOUT: +6 hours
pre:
- chain: ipi-aws-pre
test:
- ref: wait
- ref: openshift-e2e-test
post:
- chain: gather-core-dump
- chain: ipi-aws-post
+ env:
+ TIMEOUT: +6 hours
documentation: |-As per coding guidelines, "Validate step registry definitions for correctness by running make validate-step-registry".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ci-operator/step-registry/openshift/e2e/aws/openshift-e2e-aws-workflow.yaml`
around lines 5 - 6, The env block is incorrectly placed under steps; move the
env: TIMEOUT: +6 hours entry so that env: is a top-level sibling of steps: (not
nested under any step), preserving the TIMEOUT value and ensuring the
workflow-level environment variables are defined at the workflow root; after
relocating, run make validate-step-registry to confirm the schema is valid.
|
/pj-rehearse e2e-aws-ovn-dualstack-ipv6-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jechen0648: job(s): e2e-aws-ovn-dualstack-ipv6-primary-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jechen0648: job(s): e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview |
|
@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@sadasu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@sadasu, |
|
@sadasu: job(s): e2e-aws-ovn-installer-dualstack-ipv6-primary-techpreview either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv6-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv6-primary-techpreview |
efe8533 to
0194c79
Compare
|
@jechen0648: |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv6-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv6-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
0194c79 to
be20ca4
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
be20ca4 to
5677bdf
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
f5a2a74 to
86ad04c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jechen0648 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
A total of 3451 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[REHEARSALNOTIFIER]
A total of 3451 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-aws-ovn-dualstack-ipv4-primary-techpreview |
|
@jechen0648: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jechen0648: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Summary by CodeRabbit
This draft PR updates OpenShift AWS dual-stack E2E CI jobs for debugging:
These changes support longer-running, manually debugged dual-stack AWS test clusters.