Skip to content

feat: chelae/trim#11896

Merged
emmcauley merged 7 commits into
nf-core:masterfrom
fulcrumgenomics:em_chelae
Jun 12, 2026
Merged

feat: chelae/trim#11896
emmcauley merged 7 commits into
nf-core:masterfrom
fulcrumgenomics:em_chelae

Conversation

@emmcauley

@emmcauley emmcauley commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

PR checklist

Closes #11894.

This PR adds an nf-core module for chelae/trim. Chelae performs common short-read preprocessing tasks in one pass.

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@emmcauley emmcauley force-pushed the em_chelae branch 2 times, most recently from 247b79b to 831905c Compare June 6, 2026 14:43
@emmcauley emmcauley requested a review from itrujnara June 10, 2026 21:57

@itrujnara itrujnara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to nf-core. This is a great submission, I can see you have read the guidelines very thoroughly. I have just left some very picky comments about Harshil alignment to consider.

Comment thread modules/nf-core/chelae/trim/main.nf Outdated
Comment thread modules/nf-core/chelae/trim/main.nf Outdated

@itrujnara itrujnara left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, thank you

@emmcauley emmcauley added this pull request to the merge queue Jun 12, 2026
Merged via the queue into nf-core:master with commit 22edd7c Jun 12, 2026
66 checks passed
@emmcauley emmcauley deleted the em_chelae branch June 12, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

new module: chelae/trim

2 participants