Repository navigation
Add Kiro to databricks aitools install - #6908
Merged
Merged
Conversation
Kiro reads agent skills from ~/.kiro/skills (user-level) and <workspace>/.kiro/skills (workspace-level), each skill a directory holding a SKILL.md. Its loader requires frontmatter name and description, rejects a name longer than 64 characters or a description longer than 1024, and requires the name to match its directory. That is already what this repo emits, so Kiro needs only a registry entry. Verified on macOS with Kiro 1.0.182: all 29 stable skills written to ~/.kiro/skills are accepted by Kiro's loader. The only rejections in that directory were two deliberately malformed probes and two unrelated pre-existing skills whose frontmatter name does not match their directory. Kiro is IDE-first, so the `kiro` binary is frequently absent from PATH. Detection then falls back to ConfigDir and reports files-only, which is the correct state for a skills-only agent (Plugin nil). Also adds the telemetry enum and agentType case so Kiro installs are not logged as TYPE_UNSPECIFIED, keeping TestAgentTypeCoversRegistry green. Note the matching AitoolsAgentType value is still needed in enum.proto on the Universe side; only the CLI half is in this change. Follows the same shape as Goose (#6214), Gemini CLI (#6204) and Pi (#6199).
The Goose (#6214) and Gemini CLI (#6204) precedents each ship a .nextchanges fragment plus a Kiro-equivalent assertion in cmd/aitools/install_test.go and cmd/aitools/update_test.go. This branch was missing all three. The update test also needed its fixture extended, not just an assertion: it creates .pi, .gemini and .goose project skill dirs, so DetectProjectInstalled correctly reported no Kiro until .kiro was created alongside them. The production path was never at fault. libs/aitools/agents/detect_test.go is deliberately left alone. Goose and Gemini CLI have custom config-dir resolution worth covering there (XDG_CONFIG_HOME, GOOSE_PATH_ROOT); Kiro uses a plain ~/.kiro with no env override, and registry_test.go already pins both its global and project skills paths. Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Verified the recreate against #6436 — diff is byte-identical (9 files, +26/−2) and both commits keep the original author, thanks for doing it cleanly. Two things before I stamp:
Happy to approve as soon as |
Collaborator
Integration test reportCommit: 3cf337b
Top 6 slowest tests (at least 2 minutes):
|
Contributor
|
Heads up on the |
The nextchanges validator requires the fragment's trailing PR link to reference the PR that ships it. This branch supersedes the fork PR #6436. Co-authored-by: Isaac <no-reply@databricks.com>
rclarey
approved these changes
Oct 2, 2026
antonyprasad-db
approved these changes
Oct 2, 2026
antonyprasad-db
left a comment
antonyprasad-db
left a comment
Contributor
There was a problem hiding this comment.
Approved at 3cf337b5. Net diff is identical to the version I reviewed apart from the changelog fragment link, the main merge brought in nothing of its own, and all 27 checks are green. Thanks for re-homing it and for keeping the authorship intact.
Collaborator
Integration test reportCommit: c232883
8 interesting tests: 6 FAIL, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
deco-sdk-tagging Bot
added a commit
that referenced
this pull request
Oct 7, 2026
## Release v1.20.0 ### Notable Changes * Remove the Terraform deployment engine. `bundle.engine: terraform` and `DATABRICKS_BUNDLE_ENGINE=terraform` now error, and a failed migration of existing Terraform state is reported as an error instead of falling back to Terraform. To keep deploying with Terraform, use Databricks CLI v1.19.x. ([#6888](#6888), [#6889](#6889)) ### CLI * `databricks aitools install` now supports Kiro, installing Databricks agent skills into its skills directory. ([#6908](#6908)) * Fixed `databricks api` corrupting integers larger than 2^53 (such as job and pipeline ids) — request bodies and responses now preserve them exactly. ([#6884](#6884)) * Added `--auth-mode` and `--set <plugin>.<resourceKey>.authMode=obo|sp|both` to `databricks apps init` so AppKit resources can be accessed on behalf of the user, by the service principal, or both. The default stays service principal. ([#6886](#6886)) * `databricks apps init` now requires a value for every field a service principal resource binding references, prompting for missing values in an interactive terminal and otherwise failing with the `--set` key to use, instead of creating a project with unset variables. ([#6903](#6903)) * Add `databricks apps init --package-manager <npm|pnpm>` to select the package manager for Node.js templates. Infer the default quietly from template lockfiles and AppKit version, check prerequisites before creating files, and preserve template formatting and pnpm version pins. ([#6902](#6902)) * Select npm or pnpm from `packageManager` declarations and lockfiles for `apps validate` and project validation during `apps deploy`. ([#6892](#6892)) * Fix `auth docker host` reporting the credential helper as configured when its executable is missing from `PATH`. ([#6880](#6880)) * Warn when the CLI binary was built more than 6 months ago and recommend updating. ([#6898](#6898)) ### AI Runtime * Add an experimental rank-partitioned container images to AI Runtime jobs. ([#6841](#6841)) * Support snapshot fields directly under `code_source` without requiring `type` or a nested `snapshot` block. ([#6927](#6927)) * Map AIR priority and Unity Catalog image fields when converting run configurations to bundles. ([#6905](#6905)) * Add workspace backend validation to `air run --dry-run`. ([#6934](#6934)) ### Bundles * Warn that `bundle.terraform` is deprecated and has no effect since the Terraform deployment engine was removed. ([#6940](#6940)) * Direct engine now detects and applies an explicitly configured zero-value boolean or float (e.g. `gcp_attributes.use_preemptible_executors: false`, `azure_attributes.spot_bid_max_price: 0`) added to a resource first deployed without the field, matching the existing handling of an explicit integer zero. ([#6882](#6882)) * Fix `bundle deployment migrate` failing with "no such file or directory" when the Terraform state has no resources or the configuration no longer declares any of them. ([#6958](#6958)) * `bundle run` and `pipelines run` now send the per-update `development` parameter for pipelines in development mode targets. Setting `development` on a pipeline is deprecated and now emits a warning; use `mode: development` instead. ([#6863](#6863)) * Remove the hidden `bundle debug terraform` command. ([#6933](#6933)) * Add support for `run_as.group_name` at the bundle and target levels for jobs and pipelines. ([#6676](#6676)) * Fix recreating a secret scope that was deleted outside of the bundle with the direct deployment engine. ([#6970](#6970)) * Accept title-case booleans (`True`/`False`, as rendered by Azure Pipelines) for boolean variables, and accept the same boolean strings (`yes`/`no`, `on`/`off`, ...) in Python bundles as in YAML. ([#6942](#6942)) ### Dependency Updates * Bump `github.com/databricks/databricks-sdk-go` from v0.182.0 to v0.185.0. ([#6928](#6928))
This was referenced Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds Kiro to the agent registry so
databricks aitools installtreats it like any other skills-only agent. Follows the same shape as Goose (#6214), Gemini CLI (#6204) and Pi (#6199).Why
Kiro reads agent skills from
~/.kiro/skills(user-level) and<workspace>/.kiro/skills(workspace-level), each skill a directory containingSKILL.md— exactly the layout this repo already emits. Today Kiro users have to fall back todatabricks aitools install --path ~/.kiro/skills, which works but records no state, soaitools updateandaitools uninstallnever see those skills andaitools listreports every one of them asnot installed.Verification
Tested on macOS with Kiro 1.0.182.
Kiro's loader (
NodeProgressiveContextSource) rejects a skill when frontmatter is missing, whennameordescriptionis empty, whennameis outside 1–64 characters, whendescriptionexceeds 1024, or whennamedoes not equal the directory name. Everything this repo emits satisfies that.With 29 stable skills installed into
~/.kiro/skills, Kiro accepted all 29. The only rejections in that directory were two deliberately malformed probe skills added to confirm the loader was really scanning, plus two unrelated pre-existing skills whose frontmatternamedisagrees with their directory:Worth knowing for anyone testing this: Kiro resolves skills lazily when a chat session starts, not when the IDE launches. Installing and then looking at an already-open Kiro shows nothing until a new session begins.
Notes on the registry entry
SkillsSubdiris left empty because Kiro's directory is literallyskills, so the default applies.SupportsProjectScope: true— Kiro's own picker text documents both scopes.Binary: "kiro"is set, but Kiro is IDE-first so the binary is frequently absent fromPATH. Detection then falls back toConfigDirand reports files-only, which is the correct state for a skills-only agent (Plugin nil).Telemetry
Also adds
AitoolsAgentTypeKiroand the matchingagentTypecase, so Kiro installs are not logged asTYPE_UNSPECIFIEDandTestAgentTypeCoversRegistrystays green.The Universe half is already merged, so nothing is owed on the proto side. That guard's failure message notes the enum lives in
enum.proto(Universe) as well asaitools_install.go(CLI).KIRO = 10was added toAitoolsAgentType.Typeand merged to master on 2026-09-01 (universe 2524420), withProtobuf-Linter-PrandOpenAPICompatibility-Prboth green — the latter being the machine check that the additive enum value is backward compatible. The two changes are order-independent: the enum addition is additive, and the CLI only emits"KIRO"once this PR merges. So this is the complete change and needs a review rather than any follow-up work.Tests
Test coverage added alongside the existing Goose cases: registry paths and project detection in
libs/aitools/agents/registry_test.go, the skills-only assertion inagents_test.go, the project-scope declaration inlibs/aitools/installer/installer_test.go, the agent-choices assertion incmd/aitools/install_test.go, and the project-scope update path incmd/aitools/update_test.go— which needed a.kiroproject skills dir in the fixture alongside the existing.pi,.geminiand.gooseones.libs/aitools/agents/detect_test.gois deliberately not extended: Goose and Gemini CLI have custom config-dir resolution to cover there (XDG_CONFIG_HOME,GOOSE_PATH_ROOT), while Kiro uses a plain~/.kirowith no env override andregistry_test.goalready pins both of its paths.Changelog
.nextchanges/cli/aitools-kiro.md, matching the fragment the Goose and Gemini CLI PRs each shipped.Co-authored-by: Antony Prasad Thevaraj 280810845+antonyprasad-db@users.noreply.github.com
This pull request and its description were written by Isaac.