Repository navigation
Update Databricks CLI to v1.20.0 - #2241
eng-dev-ecosystem-bot wants to merge 1 commit into
Conversation
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Blocking merge: integration tests fail for every e2e job (Linux + Windows) during VSIX packaging, before any test runs. Cause: CLI v1.20.0 removed This PR stays blocked until a follow-up PR removes the Terraform bundling step from Failed run: https://github.com/databricks-eng/eng-dev-ecosystem/actions/runs/37620470676 |
Executive summary — Databricks CLI v1.19.0 → v1.20.0
Bundles
CLI
AI Runtime
Dependency updates
What could be integrated into the VS Code extension experience0. Blocker for this bump: VSIX packaging calls the removed
|
## Changes Databricks CLI v1.20.0 removes the Terraform deployment engine and the hidden `bundle debug terraform` command. Packaging called that command to download Terraform and the Databricks provider. Thus #2241, the plain version bump, fails packaging, and all e2e jobs fail with it. This PR replaces #2241. Fixes #2166: the VSIX no longer ships the Terraform v1.5.5 binary that security scans flag. - Bump the bundled CLI to v1.20.0. - Stop bundling Terraform. The VSIX now contains only `bin/databricks`. The `setupCLIDependencies.ts` packaging step and its host-CLI download are gone. - Stop setting the `DATABRICKS_TF_*` variables for CLI processes and integrated terminals, and stop writing the Terraform CLI config on activation. The extension clears its terminal variables on each activation, so old values do not stay. - Remove the Terraform-engine deprecation warning, its `bundleTerraformEngineWarning` telemetry event, and its `databricks.bundle.hideTerraformEngineWarning` state key. CLI v1.20.0 rejects `engine: terraform` in validate, so the warning cannot show. ### Backward compatibility - A bundle on the Terraform engine fails validate and deploy with the CLI error. The CLI error tells the user to remove `bundle.engine`, links the migration guide, and migrates existing Terraform state automatically. - A user can pin CLI v1.19.x or lower with `databricks.cli.path`, or put an older `databricks` first on `PATH` in a terminal. That CLI no longer gets the bundled Terraform. It downloads Terraform at runtime, and this fails on restricted networks. We accept this, because the extension moves to the direct engine. ## Tests - Unit tests with the bundled CLI v1.20.0: 1290 pass, 0 fail. - `yarn run build` and `yarn run test:lint` pass. - `./scripts/package-vsix.sh darwin-arm64`: the VSIX builds. `extension/bin/` contains only `databricks`, and the packaged `package.json` has no `terraformMetadata`. - CI integration tests (full e2e suite on the packaged VSIX, Linux and Windows): all 46 jobs pass. On the first attempt, `deploy_and_run_job` on Linux timed out while it waited for the job run status. The deploy step had already passed. The re-run of that job passed. This pull request and its description were written by Isaac. --------- Co-authored-by: Isaac <no-reply@databricks.com>
Update Databricks CLI to v1.20.0