fix(web): show workspace file names + de-cramp the tab layout#269
Merged
Conversation
The files-tab name column rendered blank: the signed-in shell caps at 960px, so the workspace view's main column was too narrow for the file table's fixed columns (size/type/visibility/menu ~392px). That collapsed the minmax(0,1fr) name track to ~0px, clipping the (present, correctly coloured) filename text to nothing. - Widen the workspace tab pages to 1200px via the --width-shell custom property the shell already reads, applied only when a rail slot is present (AccountLayout adds `account-shell--rail` to #app). Account list pages and /admin (#dashboard) keep the 960px width, and signed-in-shell.css stays untouched (admin parity preserved). - Rebalance the file-table columns so the name track always has room. - Display the file's leaf name (new tested `leafName`) instead of the full `screenshots/…/x.png` key, whose distinctive tail was otherwise ellipsized away. - Cap the connected-work rail at 6 rows with a "show N more" toggle so a busy workspace's usage/details/quick-actions aren't buried under a wall of linked PRs.
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (2)
🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
uploads-web | 9744bae | Commit Preview URL Branch Preview URL |
Jul 19 2026, 08:59 PM |
The people tab's invite card overflowed under the summary rail: `.content` is a grid with an implicit auto track, so it grew to the max-content width of the long `uploads admin invite create …` command string instead of clamping to the column, pushing the card across the rail. Clamp the content track to minmax(0, 1fr), scoped to rail pages (`account-shell--rail`), so long non-wrapping content shrinks and scrolls within its own box (the command's `overflow-x: auto` already handles that). Verified on the people tab and at a mobile-narrow width; the existing account-shell.css ≤680px restack is unaffected, and /account and /admin are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues on the shipped workspace files tab (#268), reported from the live view.
The name column rendered blank
Root cause (confirmed by inspecting the live DOM, not guesswork): the signed-in
.shellcaps atmax-width: 960px, so the workspace view's main column shrank to ~388px. The file table's fixed columns (size 90 + type 110 + visibility 100 + menu 44 + gaps ≈ 392px) consumed the whole track, collapsing theminmax(0, 1fr)name column to ~0px. The filename text was present and correctly coloured — it was clipped to nothing by the zero-width column. This is the same root cause as the "cramped" feel.Changes
--width-shellcustom property.shellalready reads, set on#apponly when a rail slot is present (AccountLayoutaddsaccount-shell--rail). Account list pages and/admin(#dashboard) keep the 960px width, andsigned-in-shell.cssis untouched, so admin parity holds.minmax(0, 1fr) 64px 64px 92px 32px) so the name track always has room even at the narrow fallback width.leafName()displaysdemographics-zodiac-….pnginstead of the fullscreenshots/either/280/…key, whose distinctive tail was being ellipsized away..contentis a grid with an implicitautotrack, so it grew to the max-content width of the longuploads admin invite create …command and pushed the invite card across the rail. Clamp the track tominmax(0, 1fr)(scoped to rail pages viaaccount-shell--rail) so long, non-wrapping content shrinks and scrolls in its own box. The sharedsigned-in-shell.css/account-shell.css(including its ≤680px mobile restack) are untouched.Verification
leafName); oxlint + oxfmt clean.Notes
Web-only (
apps/web), no changeset —apps/webis on the changesetignorelist (Workers-deployed). Admin isolation preserved:signed-in-shell.cssand all#dashboard/adminfiles have an empty diff.