Skip to content

fix(ui): allow changes preview to expand for files with only additions or deletions #23399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amirilovic wants to merge 1 commit into
base: dev
Choose a base branch
from
+1 −1
Open

fix(ui): allow changes preview to expand for files with only additions or deletions #23399

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/components/session-review.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ export const SessionReview = (props: SessionReviewProps) => {
const file = diff.file

// binary files have empty diffs that we can't render
const diffCanRender = () => diff.additions !== 0 && diff.deletions !== 0
const diffCanRender = () => diff.additions !== 0 || diff.deletions !== 0

const expanded = createMemo(() => open().includes(file))
const mounted = createMemo(() => expanded() && (!!store.visible[file] || pinned(file)))
Expand Down
Loading