fix(ui): allow changes preview to expand for files with only additions or deletions#23399
Open
amirilovic wants to merge 1 commit intoanomalyco:devfrom
Open
fix(ui): allow changes preview to expand for files with only additions or deletions#23399amirilovic wants to merge 1 commit intoanomalyco:devfrom
amirilovic wants to merge 1 commit intoanomalyco:devfrom
Conversation
…s or deletions Fixes anomalyco#23398 The diffCanRender function was using && which required both additions AND deletions to be non-zero. Changed to || so files with only additions (new files) or only deletions (deleted files) can also be expanded.
github-actions
bot
added
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #23398
Type of change
What does this PR do?
The
diffCanRenderfunction used&&instead of||, requiring both additions AND deletions to be non-zero. This prevented expanding diffs for new files (only additions) or deleted files (only deletions).Changed
&&to||so files with either additions or deletions can be expanded.How did you verify your code works?
Screenshots / recordings
N/A - logic fix, no visual changes
Checklist