Skip to content

Give the reco-counts route a distinct name #3630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 1 commit into from
Sep 12, 2026
Merged

Give the reco-counts route a distinct name #3630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/mock_vws/_flask_server/vws.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,10 +334,7 @@ def reco_counts_reports(self) -> dict[str, RecoCountsReport]:

def add_reco_counts_report(
self,
# The parameter name matches the ``RecoCountsReportStore`` protocol,
# and also happens to match the name of a route function in this
# module.
reco_counts_report: RecoCountsReport, # pylint: disable=redefined-outer-name
reco_counts_report: RecoCountsReport,
) -> None:
"""Add a reco counts report."""
with self._lock:
Expand Down Expand Up @@ -720,7 +717,7 @@ def delete_advanced_model_target_dataset(dataset_uuid: str) -> Response:
methods=[HTTPMethod.POST],
)
@beartype
def reco_counts_report(database_id: str) -> Response:
def request_reco_counts_report(database_id: str) -> Response:
"""Request a reco counts report for a database.

Fake implementation of
Expand Down
Loading