Give the reco-counts route a distinct name - #3630
Merged
Merged
Conversation
adamtheturtle
had a problem deploying
to
vuforia
September 12, 2026 12:16 — with
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flask route function had the same module-level name as the
reco_counts_reportparameter required by the storage protocol. That unrelated collision forced the protocol implementation to suppress Pylint’sredefined-outer-namewarning.Give the private route handler a descriptive, distinct Python name. Flask continues to register the same URL and behavior, while the protocol parameter keeps its accurate name and no longer needs a suppression.
Validation:
The changed module’s only local branch-coverage gap is the pre-existing process-exit branch in
get_all_cloud_databases; the changed route and store paths are covered. The aggregate local report is the repository’s known 99% when the separately partitioned real Vuforia backend is excluded; CI combines the configured partitions and remains the authoritative 100% gate.