Skip to content

Give the reco-counts route a distinct name - #3630

Merged
adamtheturtle merged 1 commit into
mainfrom
cleanup-reco-counts-route-name
Sep 12, 2026
Merged

adamtheturtle merged 1 commit into
mainfrom
cleanup-reco-counts-route-name

Conversation

@adamtheturtle

Copy link
Copy Markdown
Member

The Flask route function had the same module-level name as the reco_counts_report parameter required by the storage protocol. That unrelated collision forced the protocol implementation to suppress Pylint’s redefined-outer-name warning.

Give the private route handler a descriptive, distinct Python name. Flask continues to register the same URL and behavior, while the protocol parameter keeps its accurate name and no longer needs a suppression.

Validation:

  • all configured pre-commit hooks
  • all configured pre-push hooks (Mypy, Pyright, Pyrefly, Ty, verifytypes, docs, manifest and partition checks)
  • full non-real-backend suite: 1,947 passed, 843 skipped

The changed module’s only local branch-coverage gap is the pre-existing process-exit branch in get_all_cloud_databases; the changed route and store paths are covered. The aggregate local report is the repository’s known 99% when the separately partitioned real Vuforia backend is excluded; CI combines the configured partitions and remains the authoritative 100% gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant