Handle development firmware labels in update comparisons - #146
Merged
Merged
Conversation
|
Visit the preview URL for this PR (updated for commit 5eb338f): https://open-earable-lib-web-example--pr146-codex-fix-firmware-brzbc3je.web.app (expires Sun, 25 Oct 2026 10:31:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 7f6db4d9d00b851ad49af109fa949061904b3151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenWearables' firmware update checker throws
FormatExceptionon a real development label such as2.2.9-dev.100+g94986934.dirty, because it tries to parse9-devas an integer. Compare semantic versions using the existingpub_semverdependency, preserve prerelease ordering, ignore build hashes, and accept release-tag prefixes and legacy trailing NUL bytes. Unrecognized labels return no update recommendation instead of throwing.Six new regression tests cover stable versions, the observed development label, prerelease ordering, build metadata, tag prefixes/legacy terminators and malformed input. They fail on the original implementation and pass with this fix. The complete SDK test suite passes (17 tests); analysis of the changed files reports no issues. This fixes the SDK source; the installed phone app still requires a release containing the change.