revert: use GitHub App token for pull-translations PR creation - #2706
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2680.
pull_translations's push token fromGITHUB_TOKENto a minted GitHub App token, to work around GitHub's anti-recursion rule (pushes made with the defaultGITHUB_TOKENnever trigger other push-triggered workflows, soci.yaml's required checks never ran on anylokalise-update-*branch).secrets.APP_ID/secrets.APP_SECRETonly hascontents: write(all its only other consumer,ci.yaml'sderive-commitjob, ever needed) — notpull_requests: write. So the very next step, actually opening the PR via the API, now fails outright withResource not accessible by integration. This is a regression: before fix: use GitHub App token for pull-translations PR creation #2680 the PR at least opened (it just sat stuck on required checks); after fix: use GitHub App token for pull-translations PR creation #2680 it doesn't open at all.Note: this is unrelated to
check-for-manual-translations(#2671, #2674), which is fixed and unaffected by this revert.Follow-up (manual, until a proper fix lands)
ci.yaml's required checks still won't run automatically onlokalise-update-*branches after this revert. Whoever runs "Pull Translations" next: once the PR appears, check out the branch locally, rebase/merge latestmaininto it, andgit pushwith your own credentials — a normal human-authenticated push isn't subject to the anti-recursion rule and will triggerci.yamlnormally, letting the PR become mergeable.Test plan
mainResource not accessible by integration)check-for-manual-translationsstill passes on it