Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion auth/api-client/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
pytest==8.2.0
pytest==9.0.3
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 9.0.3 for pytest does not exist on PyPI. The current stable version is in the 8.x range. This will cause installation to fail. Please check if this was a typo for a version like 8.3.3.

backoff==2.2.1
6 changes: 3 additions & 3 deletions auth/api-client/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
google-api-python-client==2.131.0
google-api-python-client==2.196.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This PR updates production dependencies in addition to pytest. Per the general rules, PRs should be focused on a single change. Consider splitting these updates or updating the PR title to reflect the broader scope.

References
  1. To simplify the review process, pull requests should be focused on a single change.

google-auth-httplib2==0.2.0
google-auth==2.38.0
google-cloud-api-keys==0.5.13
google-cloud-api-keys==0.8.0
google-cloud-compute==1.11.0
google-cloud-language==2.15.1
google-cloud-storage==2.9.0
google-cloud-storage==3.10.1
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The version 3.10.1 for google-cloud-storage does not exist on PyPI. The current stable version is in the 2.x range. This update will likely cause installation failures. Please check if this was a typo for 2.10.1.

2 changes: 1 addition & 1 deletion auth/custom-credentials/okta/noxfile_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.

TEST_CONFIG_OVERRIDE = {
"ignored_versions": ["2.7", "3.6", "3.7", "3.8", "3.9", "3.10", "3.11", "3.12"],
"ignored_versions": ["2.7", "3.6", "3.7", "3.8", "3.9", "3.14"],
}
2 changes: 1 addition & 1 deletion auth/custom-credentials/okta/requirements-test.txt
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
-r requirements.txt
pytest==7.1.2
pytest==9.0.3