chore(multiple samples) Update pytest dependencies to solve dependabot security alerts.#14147
chore(multiple samples) Update pytest dependencies to solve dependabot security alerts.#14147XrossFox wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Conversation
dpendencies that were failing to build.
product-auto-label
Bot
added
samples
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates several dependencies, but the review identifies that the specified versions for pytest and google-cloud-storage do not exist on PyPI, which will cause installation failures. Additionally, the reviewer suggests splitting the PR to separate test and production dependency updates to follow the best practice of focusing on a single change per pull request.
| @@ -1,2 +1,2 @@ | |||
| pytest==8.2.0 | |||
| pytest==9.0.3 | |||
There was a problem hiding this comment.
The version 9.0.3 for pytest does not exist on PyPI. The current stable version is in the 8.x range. This will cause installation to fail. Please check if this was a typo for a version like 8.3.3.
| google-cloud-compute==1.11.0 | ||
| google-cloud-language==2.15.1 | ||
| google-cloud-storage==2.9.0 | ||
| google-cloud-storage==3.10.1 |
There was a problem hiding this comment.
The version 3.10.1 for google-cloud-storage does not exist on PyPI. The current stable version is in the 2.x range. This update will likely cause installation failures. Please check if this was a typo for 2.10.1.
| @@ -1,7 +1,7 @@ | |||
| google-api-python-client==2.131.0 | |||
| google-api-python-client==2.196.0 | |||
There was a problem hiding this comment.
This PR updates production dependencies in addition to pytest. Per the general rules, PRs should be focused on a single change. Consider splitting these updates or updating the PR title to reflect the broader scope.
References
- To simplify the review process, pull requests should be focused on a single change.
1 participant
WIP
Description
Fixes b/511241844
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)