session: drop ??= in ext(), plus a biome format pass over ./src - #1364
Merged
Conversation
biome's noAssignInExpressions flagged the assignment inside `const ext =
(envelope.ext ??= {})`. Use an explicit `if (envelope.ext === undefined)`
statement then read it back; behavior is identical.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
`bun run format` (biome check --write --indent-style=space --line-width=120) reformats these files, which had drifted since biome is not run in CI. Pure formatting - line wrapping to 120 cols, no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
yagop
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits:
session.tsfix —bun run format(biome) flaggednoAssignInExpressionsonconst ext = (envelope.ext ??= {})inSessionHandle.ext(). Replaced with an explicit statement (no??=, no assignment-in-expression):Behavior identical.
biome format pass over
./src— 7 files that had drifted (biome isn't run in CI, onlylint:core/check:edgeare). Pure formatting: line-wrapping to 120 cols, no behavior change.Together these make
bun run formatexit clean.npm run typecheck+ 56 session tests pass.🤖 Generated with Claude Code