Skip to content

fix(lint-configs): Suppress clang-tidy unnecessary-copy warnings for std::shared_ptr as the copy is necessary for reference counting. #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidlion merged 1 commit into from
Jul 2, 2026
Merged

fix(lint-configs): Suppress clang-tidy unnecessary-copy warnings for std::shared_ptr as the copy is necessary for reference counting. #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion exports/lint-configs/.clang-tidy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,14 @@ CheckOptions:
cert-str34-c.CharTypdefsToIgnore: "int8_t"

# This is necessary to allow simple classes (with all members being public) that have a
# constructor
# constructor.
misc-non-private-member-variables-in-classes.IgnoreClassesWithAllMemberVariablesBeingPublic: true

# Passing a reference counted type by reference will skip the usage of the reference count, which
# risks lifetime related bugs.
performance-unnecessary-copy-initialization.AllowedTypes: "std::shared_ptr"
performance-unnecessary-value-param.AllowedTypes: "std::shared_ptr"

# NOTE: In the naming rules below, a rule may imply another (e.g., `ClassCase` seems to imply
# `AbstractClassCase`), so ideally we'd only specify the parent rule if we didn't need to
# customize the child rules. However, these relationships aren't documented, so we can't rely on
Expand Down
Loading