Repository navigation
fix(chat): fetch public keys per user - #96
boboliu-1010 wants to merge 1 commit into
Conversation
|
Big fan of xurl, thanks for building and maintaining it. Confirming the same behavior on a matching setup, and +1 for the per-user route. Environment: macOS arm64, xurl v1.3.1, OAuth 2.0 user context, X app on Pay-per-use, chat keys restored via Juicebox. Repro before the fix:
Verified this PR branch locally: built with |
|
Thanks for the detailed independent verification — especially testing a live thread with a KeyChange event and repeated reads. That confirms the per-user route fixes the issue in another production setup. No additional changes are planned from my side; this is ready for maintainer review. |
|
Independently verified this PR at The official v1.3.4 binary still reproduces #94: with the same explicitly selected app and OAuth 2.0 user, each participant's With this PR:
No message sending, read receipts, key rotation, or weakened signature verification was needed. These are bounded-read/media tests, not a claim of exhaustive history coverage. This is a working fix for an existing released-client failure. Could a maintainer review it for inclusion in a release? Thanks for the focused patch. Separate, non-blocking follow-up: the failing released |
fe2bcb4 to
58fb00f
Compare
Summary
GET /2/users/:id/public_keysinstead of the batch endpointuser_idon each returned keyWhy
Some production X apps can access the per-user public-key endpoint but receive
client-not-enrolledfromGET /2/users/public_keys?ids=..., even when the batch contains a single user. That preventsxurl chat readfrom loading signing keys and verifying messages.Using the per-user route trades one batch request for one request per participant, but works across apps that are not enrolled for the batch endpoint and preserves the same result shape for callers.
Verification
go test ./apigo test ./...go vet ./...Fixes #94