Repository navigation
fix(chat): sign the timer and screen-capture setting in add-members - #100
Merged
Merged
Conversation
xurl chat add-members failed with "Invalid action signature" on a group whose message timer (message_ttl_ms) or screen-capture blocking setting (screen_capture_blocking_enabled) had been set. The member-add action signature covers the group's current state. addGroupMembers already reads both settings from the conversation, but it never passed them to PrepareGroupMembersChange, so the signed state reported them as unset and didn't match the group. Pass CurrentTTLMsec and CurrentScreenCaptureBlockingEnabled from the conversation metadata. The new TestAddGroupMembersSignsGroupSettings checks that both values reach the signed member-add payload; it fails without the fix.
santiagomed
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xurl chat add-members failed with "Invalid action signature" on a group whose message timer (message_ttl_ms) or screen-capture blocking setting (screen_capture_blocking_enabled) had been set.
The member-add action signature covers the group's current state. addGroupMembers already reads both settings from the conversation, but it never passed them to PrepareGroupMembersChange, so the signed state reported them as unset and didn't match the group.
Pass CurrentTTLMsec and CurrentScreenCaptureBlockingEnabled from the conversation metadata. The new TestAddGroupMembersSignsGroupSettings checks that both values reach the signed member-add payload; it fails without the fix.