style(mahalanobis): drop unused import, fix isort drift#3582
Open
brendancol wants to merge 2 commits into
Open
style(mahalanobis): drop unused import, fix isort drift#3582brendancol wants to merge 2 commits into
brendancol wants to merge 2 commits into
Conversation
Cat 3 (F401): remove unused is_dask_cupy import from xrspatial.utils. Cat 4 (isort): reformat the xrspatial.utils import block to line_length=100. flake8 and isort are clean after the change; no behaviour change. dask+cupy dispatch goes through ArrayTypeFunctionMapping, not a direct is_dask_cupy check, so the removed name had no references.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style-only cleanup of
xrspatial/mahalanobis.py, limited to what flake8 and isort flag under the existing setup.cfg (max-line-length=100, line_length=100).is_dask_cupyimport fromxrspatial.utils.xrspatial.utilsimport block to line_length=100.No behaviour change. The removed name had no references in the module; dask+cupy dispatch goes through
ArrayTypeFunctionMapping. flake8 and isort are clean after the change, and the 24 tests in test_mahalanobis.py pass.