Remove ios and android build_preflight - #773
Merged
mokagio merged 5 commits intoAug 26, 2026
Merged
Conversation
The last remaining callers are WordPress-iOS and WooCommerce iOS, each with an approved PR to drop the call. The action ran `configure_apply`, which will become a no-op or a failure once we move to `a8c-secrets`. --- Generated with the help of Grok, https://x.ai/grok Co-Authored-By: Grok 4.6 <noreply@x.ai>
--- Generated with the help of Grok, https://x.ai/grok Co-Authored-By: Grok 4.6 <noreply@x.ai>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the deprecated ios_build_preflight Fastlane action from the Release Toolkit gem, and documents the breaking change for the upcoming 15.0.0 release so downstream clients can migrate cleanly.
Changes:
- Remove the
ios_build_preflightiOS action implementation. - Add migration guidance for consumers upgrading to 15.0.0.
- Add a Breaking Changes entry to the CHANGELOG for
ios_build_preflightremoval.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
lib/fastlane/plugin/wpmreleasetoolkit/actions/ios/ios_build_preflight.rb |
Deletes the ios_build_preflight action implementation. |
MIGRATION.md |
Documents the required migration steps for 14.x → 15.0.0 regarding this removal. |
CHANGELOG.md |
Records the breaking change under ## Trunk so it’s surfaced in release notes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
--- Generated with the help of Grok, https://x.ai/grok Co-Authored-By: Grok 4.6 <noreply@x.ai>
All four client removals have landed. Same breaking change as the ios_build_preflight deletion. --- Generated with the help of Grok, https://x.ai/grok Co-Authored-By: Grok 4.6 <noreply@x.ai>
mokagio
changed the title
mokagio
enabled auto-merge
August 26, 2026 04:06
iangmaia
reviewed
Aug 26, 2026
mokagio
deleted the
ainfra-2960-remove-ios_build_preflight-from-release-toolkit-after
branch
August 26, 2026 15:15
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Remove the
ios_build_preflightandandroid_build_preflightactions.Android callers have already landed.
iOS callers still have unmerged PRs: WordPress-iOS#25934, woocommerce-ios#17759.
Breaking change for 15.0.0 (AINFRA-2961).
Checklist before requesting a review
bundle exec rubocopto test for code style violations and recommendations.specs/*_spec.rb) if applicable. None — neither action had a spec.bundle exec rspecto run the whole test suite and ensure all your tests pass. 1007 examples, 0 failures.CHANGELOG.mdfile to describe your changes under the appropriate existing###subsection of the existing## Trunksection.MIGRATION.mdfile to describe how the changes will affect the migration from the previous major version and what the clients will need to change and consider.