Skip to content

Mark the RS lists with a debug-only "(RS)" title suffix - #23270

Open
nbradbury wants to merge 1 commit into
trunkfrom
rs-list-debug-watermark
Open

Mark the RS lists with a debug-only "(RS)" title suffix#23270
nbradbury wants to merge 1 commit into
trunkfrom
rs-list-debug-watermark

Conversation

@nbradbury

@nbradbury nbradbury commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Description

Posts, Pages, and Comments each have two implementations: legacy FluxC and WordPress-RS. They look close enough that it's hard to tell which one is on screen, which is a problem for us when testing.

This PR resolves this by adding (RS) to the screen titles in debug builds only.

rs

Testing instructions

RS screens show the suffix (debug build)

  1. Install a debug build and sign in to a site that authenticates with an application password.
  2. My Site → Posts.
  • Title reads "Blog Posts (RS)"
  1. Back, then My Site → Pages.
  • Title reads "Site Pages (RS)"
  1. Back, then My Site → Comments.
  • Title reads "Comments (RS)"

FluxC screens have no suffix

  1. On the same site, go to My Site and tap the drafts or scheduled posts card.
  • The legacy list opens with title "Blog Posts" — no suffix
  1. Sign in to a WordPress.com site that has no application password, then open Posts, Pages, and Comments.
  • All three open the legacy screens with no suffix

The posts, pages, and comments screens each have two implementations —
legacy FluxC and wordpress-rs — chosen at runtime by SiteUtils.canUseWpRs.
They look alike, and several entry points bypass that branch and always
open the legacy screen, so on one site you can reach both without knowing
which is which.

Add rsDebugTitle(), which appends "(RS)" to a title in debug builds only,
and use it for the three RS list top app bars. No suffix means FluxC.
@nbradbury nbradbury added unit-tests-exemption WP-RS Related to wordpress-rs labels Aug 28, 2026
@dangermattic

dangermattic commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr23270-85e0617
Build Number1498
Application IDcom.jetpack.android.prealpha
Commit85e0617
Installation URL6ednqcjmctuio
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot

Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr23270-85e0617
Build Number1498
Application IDorg.wordpress.android.prealpha
Commit85e0617
Installation URL6tala3td5g7jo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.80%. Comparing base (e6f795f) to head (85e0617).

Files with missing lines Patch % Lines
...roid/ui/commentsrs/screens/CommentsRsListScreen.kt 0.00% 1 Missing ⚠️
...ss/android/ui/pagesrs/screens/PagesRsListScreen.kt 0.00% 1 Missing ⚠️
...ess/android/ui/postsrs/screens/PostRsListScreen.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #23270   +/-   ##
=======================================
  Coverage   37.80%   37.80%           
=======================================
  Files        2348     2348           
  Lines      128445   128445           
  Branches    17805    17805           
=======================================
  Hits        48560    48560           
  Misses      75925    75925           
  Partials     3960     3960           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nbradbury
nbradbury marked this pull request as ready for review August 28, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

unit-tests-exemption WP-RS Related to wordpress-rs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants