Mark the RS lists with a debug-only "(RS)" title suffix - #23270
Open
nbradbury wants to merge 1 commit into
Open
Conversation
The posts, pages, and comments screens each have two implementations — legacy FluxC and wordpress-rs — chosen at runtime by SiteUtils.canUseWpRs. They look alike, and several entry points bypass that branch and always open the legacy screen, so on one site you can reach both without knowing which is which. Add rsDebugTitle(), which appends "(RS)" to a title in debug builds only, and use it for the three RS list top app bars. No suffix means FluxC.
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #23270 +/- ##
=======================================
Coverage 37.80% 37.80%
=======================================
Files 2348 2348
Lines 128445 128445
Branches 17805 17805
=======================================
Hits 48560 48560
Misses 75925 75925
Partials 3960 3960 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Posts, Pages, and Comments each have two implementations: legacy FluxC and WordPress-RS. They look close enough that it's hard to tell which one is on screen, which is a problem for us when testing.
This PR resolves this by adding
(RS)to the screen titles in debug builds only.Testing instructions
RS screens show the suffix (debug build)
FluxC screens have no suffix