Skip to content

fix(ios): don't start a media upload for a torn-down editor #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jkmassel wants to merge 1 commit into from
Open

fix(ios): don't start a media upload for a torn-down editor #626

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ios/Sources/GutenbergKit/Sources/Media/MediaUploadServer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,10 @@ final class MediaUploadServer: Sendable {
private static func passthroughResponse(
_ request: HTTPServer.Request, query: String, context: UploadContext
) async throws -> HTTPResponse {
// As in `processAndUpload`: don't put bytes on the wire for a torn-down
// editor, regardless of whether the HTTP client honors cancellation.
try Task.checkCancellation()

Logger.uploadServer.debug("Passthrough: forwarding original request body to WordPress")
guard let body = request.parsed.body,
let contentType = request.parsed.header("Content-Type"),
Expand Down Expand Up @@ -313,6 +317,13 @@ final class MediaUploadServer: Sendable {
}
}

// The editor was torn down (or the client disconnected) while we processed.
// Don't start an outbound upload whose response nobody will read — it would
// create an attachment neither GutenbergKit nor the host knows to clean up.
// Checking here rather than relying on the HTTP client to notice cancellation
// keeps this true for a host-injected `URLSessionProtocol` that doesn't.
try Task.checkCancellation()

// Step 2: Upload to remote WordPress
if let delegate = context.uploadDelegate,
let result = try await delegate.uploadFile(at: uploadURL, mimeType: uploadMimeType, filename: uploadFilename) {
Expand Down
Loading