chore: ignore Playwright output in ESLint and Prettier - #615
Merged
dcalhoun merged 1 commit intoSep 2, 2026
Conversation
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/615")Built from c42efce |
Local E2E runs write e2e/test-results/ and playwright-report/, which git already ignores but the linters still walked. The generated report scripts produced hundreds of ESLint errors and Prettier diffs unrelated to project code. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VnQd7G77gehA2PgnzKvFei
dcalhoun
force-pushed
the
chore/ignore-playwright-output
branch
from
September 2, 2026 13:30
7fd8aed to
c42efce
Compare
dcalhoun
marked this pull request as ready for review
September 2, 2026 13:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add the Playwright output directories,
e2e/test-results/andplaywright-report/, to.eslintignoreand.prettierignore.Why?
Git already ignores both directories, but the linters did not. After a local
make test-e2erun,make lint-jsfailed with 227 errors, all inside the generatedplaywright-report/trace/*.jsbundles, andnpm run formatwould rewrite 13 generated files. None of it relates to project code, and the failure only appears on machines that have run the E2E suite locally.How?
Mirror the existing
.gitignoreentries in both linter ignore files.Testing Instructions
make test-e2eat least once so both directories exist.make lint-js. It passes.npx prettier --check playwright-report e2e/test-results. It reports nothing to fix.npx prettier --check playwright-report e2e/test-results --ignore-path /dev/null. It flags the generated files, confirming the ignore entries are what suppress them.Accessibility Testing Instructions
N/A. No UI changes.
Screenshots or screencast
N/A
🤖 Generated with Claude Code
https://claude.ai/code/session_01VnQd7G77gehA2PgnzKvFei