Reorder log message in auth.c - #1175
Merged
Merged
Conversation
padelsbach
force-pushed
the
auth-dot-c-long-logs
branch
from
August 18, 2026 20:30
b03c56b to
fcad22c
Compare
padelsbach
force-pushed
the
auth-dot-c-long-logs
branch
from
August 18, 2026 21:17
fcad22c to
bb65fef
Compare
ejohnstown
requested review from
wolfSSL-Fenrir-bot
and
a lite review from Copilot
August 18, 2026 21:21
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts wolfSSHD error log wording so that long file paths are moved to the end of the log line, reducing the chance that the actionable rejection reason is truncated in capped log output.
Changes:
- Reorders multiple “Refusing to load …” log messages in
wolfSSHD_OpenSecureFile()to put the path at the end of the line. - Reorders the StrictModes failure log in
SearchKeysFile()to put the keys file path at the end. - Updates a test comment to reflect the local host key copy used by the StrictModes negative test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| apps/wolfsshd/test/run_all_sshd_tests.sh | Updates comment in the StrictModes negative host-key test section (test logic remains compatible via substring greps). |
| apps/wolfsshd/auth.c | Reorders log format strings so rejection reasons appear before the potentially-long file path. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
approved these changes
Aug 18, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1175
Scan targets checked: wolfssh-bugs, wolfssh-src
No new issues found in the changed files. ✅
ejohnstown
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move path to end of log line to avoid early truncation of the log