TC3: expose DFLASH mode as option - #837
Draft
bigbrett wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Exposes an AURIX TC3 build-time option to support DFLASH provisioned in single-ended sensing mode, adjusting both compile-time configuration and NVM image sizing.
Changes:
- Add a Makefile option (
TC3_CFG_DFLASH_SINGLE_ENDED=1) that defines a corresponding C preprocessor macro. - Adjust
WH_NVM_PART_SIZEbased on the selected DFLASH sensing mode.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1910
to
+1915
| # NVM partition is half of DFLASH1; bank size depends on sensing mode | ||
| ifeq ($(TC3_CFG_DFLASH_SINGLE_ENDED),1) | ||
| WH_NVM_PART_SIZE ?= 0x10000 | ||
| else | ||
| WH_NVM_PART_SIZE ?= 0x8000 | ||
| endif |
Comment on lines
+1891
to
+1892
| # Set TC3_CFG_DFLASH_SINGLE_ENDED=1 for devices with DFLASH provisioned in single | ||
| # ended mode (default expects complement sensing) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exposes support for a different flash mode on TC3