Repository navigation
Add the wolfCOSE manual to the shared documentation build - #284
Draft
aidangarske wants to merge 1 commit into
Draft
aidangarske wants to merge 1 commit into
aidangarske wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The mutable default ref can produce stale Docker-cached documentation after upstream changes.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds wolfCOSE to the shared documentation build, sourcing its manual from the upstream repository after wolfCOSE PR #91 merges.
Changes:
- Adds wolfCOSE HTML/PDF build targets.
- Fetches and optionally pins upstream wolfCOSE sources.
- Adds CI coverage and usage documentation.
| File | Description |
|---|---|
wolfCOSE/Makefile |
Fetches sources and invokes the upstream adapter. |
wolfCOSE/.gitignore |
Excludes generated artifacts and checkout. |
README.md |
Documents wolfCOSE build options. |
Makefile |
Adds the root wolfCOSE target. |
Dockerfile |
Builds wolfCOSE PDF and HTML from one revision. |
.github/workflows/build-check.yml |
Adds a pinned wolfCOSE CI build. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+7
to
+8
| WOLFCOSE_REF ?= main | ||
| DOCKER_CMD=DOCKER_BUILDKIT=1 docker build $(DOCKER_CMD_EXTRA_ARGS) -t doc_build --build-arg MANPATH=$(MANPATH) --build-arg PDFFILE=$(PDFFILE) --build-arg V=$(V) --build-arg WOLFCOSE_REF=$(WOLFCOSE_REF) --target=manual --output=build -f Dockerfile . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSL/wolfCOSE#91 needs merged first