Skip to content

Remove the unused StrictComparison::to_compare_operator #9405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
connortsui20 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove the unused StrictComparison::to_compare_operator #9405

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions vortex-array/src/scalar_fn/fns/between/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ use crate::scalar_fn::ChildName;
use crate::scalar_fn::ExecutionArgs;
use crate::scalar_fn::ScalarFnId;
use crate::scalar_fn::ScalarFnVTable;
use crate::scalar_fn::fns::operators::CompareOperator;
use crate::scalar_fn::fns::operators::Operator;

#[derive(Debug, Clone, PartialEq, Eq, Hash)]
Expand Down Expand Up @@ -67,13 +66,6 @@ pub enum StrictComparison {
}

impl StrictComparison {
pub const fn to_compare_operator(&self) -> CompareOperator {
match self {
StrictComparison::Strict => CompareOperator::Lt,
StrictComparison::NonStrict => CompareOperator::Lte,
}
}

pub const fn to_operator(&self) -> Operator {
match self {
StrictComparison::Strict => Operator::Lt,
Expand Down
Loading