Skip to content

Use aggregate descriptors for zoned stats#7938

Draft
gatesn wants to merge 1 commit into
ngates/stats-7707/zoned-statfn-pruningfrom
ngates/stats-7707/aggregate-zoned-stats
Draft

Use aggregate descriptors for zoned stats#7938
gatesn wants to merge 1 commit into
ngates/stats-7707/zoned-statfn-pruningfrom
ngates/stats-7707/aggregate-zoned-stats

Conversation

@gatesn
Copy link
Copy Markdown
Contributor

@gatesn gatesn commented May 15, 2026

Summary

  • store zoned stats as aggregate-function partials keyed by AggregateFnRef display descriptors
  • add magic-prefixed protobuf zoned metadata with legacy Stat bitset decoding
  • lower StatFn against descriptor-named zone columns with legacy null/nan count bridges preserved

Checks

  • cargo build -p vortex-layout
  • cargo build -p vortex-tui
  • cargo test -p vortex-layout zoned
  • cargo test -p vortex-array stat_expr
  • cargo test -p vortex-array min_
  • cargo test -p vortex-array max_
  • cargo test -p vortex-sqllogictest --test sqllogictests
  • cargo +nightly fmt --all
  • ./scripts/public-api.sh
  • cargo clippy --all-targets --all-features
  • git diff --check

@gatesn gatesn added the changelog/feature A new feature label May 15, 2026
@gatesn gatesn mentioned this pull request May 15, 2026
39 tasks
@gatesn gatesn force-pushed the ngates/stats-7707/aggregate-zoned-stats branch from 772d188 to 6e1ab90 Compare May 15, 2026 03:51
@gatesn gatesn force-pushed the ngates/stats-7707/zoned-statfn-pruning branch from c69b282 to f9cf88c Compare May 15, 2026 03:51
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 1216 untouched benchmarks


Comparing ngates/stats-7707/aggregate-zoned-stats (8b3da0d) with ngates/stats-7707/zoned-statfn-pruning (096128a)

Open in CodSpeed

@gatesn gatesn force-pushed the ngates/stats-7707/aggregate-zoned-stats branch 2 times, most recently from bc8f53c to 6ceb393 Compare May 15, 2026 08:46
@gatesn gatesn force-pushed the ngates/stats-7707/zoned-statfn-pruning branch from f9cf88c to ed63b11 Compare May 15, 2026 08:46
@gatesn gatesn force-pushed the ngates/stats-7707/aggregate-zoned-stats branch from 6ceb393 to 549e240 Compare May 15, 2026 09:16
@gatesn gatesn force-pushed the ngates/stats-7707/zoned-statfn-pruning branch from ed63b11 to 0d3003c Compare May 15, 2026 09:16
Signed-off-by: Nicholas Gates <nick@nickgates.com>
@gatesn gatesn force-pushed the ngates/stats-7707/aggregate-zoned-stats branch from 549e240 to 8b3da0d Compare May 15, 2026 09:23
@gatesn gatesn force-pushed the ngates/stats-7707/zoned-statfn-pruning branch from 0d3003c to 096128a Compare May 15, 2026 09:23
@tl-dr-review tl-dr-review Bot added the tldr label May 15, 2026
@gatesn gatesn added tldr and removed tldr labels May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant