fix(implode): clean long paths on Windows - #2510
Merged
Merged
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.69 MiB | 10.69 MiB | 0 B (0.00%) |
vp (Linux x64) |
gzip -9 | 4.63 MiB | 4.63 MiB | +4 B (+0.00%) |
| NAPI (Linux x64) | Binary | 32.19 MiB | 32.19 MiB | 0 B (0.00%) |
| NAPI (Linux x64) | gzip -9 | 12.69 MiB | 12.69 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
Binary | 7.98 MiB | 7.98 MiB | 0 B (0.00%) |
vp (macOS ARM64) |
gzip -9 | 4.04 MiB | 4.04 MiB | +9 B (+0.00%) |
| NAPI (macOS ARM64) | Binary | 39.79 MiB | 39.79 MiB | 0 B (0.00%) |
| NAPI (macOS ARM64) | gzip -9 | 16.98 MiB | 16.98 MiB | 0 B (0.00%) |
vp (Windows x64) |
Binary | 8.58 MiB | 8.59 MiB | +5.50 KiB (+0.06%) |
vp (Windows x64) |
gzip -9 | 3.74 MiB | 3.75 MiB | +4.06 KiB (+0.11%) |
| NAPI (Windows x64) | Binary | 27.03 MiB | 27.03 MiB | 0 B (0.00%) |
| NAPI (Windows x64) | gzip -9 | 10.75 MiB | 10.75 MiB | +3 B (+0.00%) |
| Trampoline (Windows x64) | Binary | 216.50 KiB | 216.50 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 104.34 KiB | 104.34 KiB | 0 B (0.00%) |
| Installer (Windows x64) | Binary | 4.48 MiB | 4.48 MiB | 0 B (0.00%) |
| Installer (Windows x64) | gzip -9 | 2.10 MiB | 2.10 MiB | -1 B (-0.00%) |
fengmk2
marked this pull request as ready for review
August 20, 2026 11:43
fengmk2
added
the
preview-build
Contributor
Registry bridge build (
|
| Package | Version |
|---|---|
vite-plus |
0.0.0-commit.b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45 |
@voidzero-dev/vite-plus-core |
0.0.0-commit.b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45 |
Install the Vite+ CLI built from this commit, then migrate a project:
# macOS / Linux
curl -fsSL https://raw.githubusercontent.com/voidzero-dev/vite-plus/b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45/packages/cli/install.sh | VP_PR_VERSION=2510 bash# Windows (PowerShell)
$env:VP_PR_VERSION="2510"; irm https://raw.githubusercontent.com/voidzero-dev/vite-plus/b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45/packages/cli/install.ps1 | iexOr download the standalone Windows installer built from this commit:
| Architecture | Installer |
|---|---|
| x64 | vp-setup-x86_64-pc-windows-msvc.exe |
| Arm64 | vp-setup-aarch64-pc-windows-msvc.exe |
GitHub requires you to sign in and downloads each installer as a ZIP artifact. Extract vp-setup.exe, then run it against this preview build:
.\vp-setup.exe --version "0.0.0-commit.b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45" --registry "https://registry-bridge.viteplus.dev/"After installing, upgrade the current project's vite-plus to this test build with:
vp migrateOr point your package manager at the bridge registry https://registry-bridge.viteplus.dev/:
| Package manager | Registry config |
|---|---|
| npm / pnpm / Bun | .npmrc: registry=https://registry-bridge.viteplus.dev/ |
| Yarn (v2+) | .yarnrc.yml: npmRegistryServer: "https://registry-bridge.viteplus.dev/" |
Then pin the build (vite aliases to vite-plus-core; pnpm can use a catalog, npm an overrides entry):
{
"devDependencies": {
"vite-plus": "0.0.0-commit.b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45",
"vite": "npm:@voidzero-dev/vite-plus-core@0.0.0-commit.b3de9bd37039847cb262ea7bc99a4bf3bdf8ef45"
}
}
Contributor
🐳 Docker preview imageBuilt from this PR's registry bridge build:
# remove any stale local copy from a previous run, then pull fresh
docker rmi ghcr.io/voidzero-dev/vite-plus:pr-2510 2>/dev/null; docker pull ghcr.io/voidzero-dev/vite-plus:pr-2510Quick check: docker run --rm ghcr.io/voidzero-dev/vite-plus:pr-2510 vp --versionSee docs/guide/docker.md for usage. |
wan9chi
approved these changes
Aug 21, 2026
fengmk2
force-pushed
the
fix/implode-windows-long-paths
branch
from
August 21, 2026 03:09
860f78e to
e221000
Compare
fengmk2
force-pushed
the
fix/implode-windows-long-paths
branch
from
August 21, 2026 03:53
e221000 to
8ed9517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes #2502.
On Windows,
vp implodenow starts a native cleanup helper from a temporary executable. The helper waits for the original process. It removes only the renamed Vite+ root. It retries the operation when Windows locks a file. It writes an error log if it cannot remove the root.PowerShell now removes only the temporary helper executable. It does not traverse the Vite+ data tree.
Rust tests cover long paths, locked files, junctions, and an immediate reinstall. The Windows standalone install workflow tests monolithic and split layouts.