test(cli): stabilize global snap tests against pnpm v11#1528
Merged
Conversation
Five fixtures that ran `vp install` or `vp migrate` had no `packageManager` set, so vite_install fell through to its `latest` default (now pnpm v11). pnpm v11 fails the install with `ERR_PNPM_IGNORED_BUILDS` for transitive esbuild/sharp build scripts where v10 only warned. Pin each fixture to `pnpm@10.33.2` to match the repo's own packageManager. Separately, `create-framework-shim-astro`'s install step also tripped the strict-CI builds check on a clean runner; pass `--ignore-scripts` so pnpm doesn't try to run them at all.
✅ Deploy Preview for viteplus-preview canceled.
|
Member
Author
How to use the Graphite Merge QueueAdd the label auto-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
branchseer
approved these changes
May 7, 2026
Same root cause as 7d65d0c: missing `packageManager` makes vite_install fall through to pnpm@latest (now v11), which fails the install on transitive build scripts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five fixtures that ran
vp installorvp migratehad nopackageManagerset, so vite_install fell through to itslatestdefault (now pnpm v11). pnpm v11 fails the install with
ERR_PNPM_IGNORED_BUILDSfor transitive esbuild/sharp build scriptswhere v10 only warned. Pin each fixture to
pnpm@10.33.2to match therepo's own packageManager.
Separately,
create-framework-shim-astro's install step also trippedthe strict-CI builds check on a clean runner; pass
--ignore-scriptsso pnpm doesn't try to run them at all.